From fc9c5510253e65cbaa9d4afcb2a207035d68ac35 Mon Sep 17 00:00:00 2001 From: "Jonathan H. Wage" Date: Mon, 21 Apr 2025 11:22:52 -0400 Subject: [PATCH] Revert "[Messenger] Add call to `gc_collect_cycles()` after each message is handled" This reverts commit b0df65ae9aeb86a650abe9cd4d627c3bade66000. --- .../Component/Messenger/Tests/WorkerTest.php | 19 ------------------- src/Symfony/Component/Messenger/Worker.php | 2 -- 2 files changed, 21 deletions(-) diff --git a/src/Symfony/Component/Messenger/Tests/WorkerTest.php b/src/Symfony/Component/Messenger/Tests/WorkerTest.php index cb36ce93555b1..5cf8c387b1d35 100644 --- a/src/Symfony/Component/Messenger/Tests/WorkerTest.php +++ b/src/Symfony/Component/Messenger/Tests/WorkerTest.php @@ -584,25 +584,6 @@ public function testFlushBatchOnStop() $this->assertSame($expectedMessages, $handler->processedMessages); } - - public function testGcCollectCyclesIsCalledOnMessageHandle() - { - $apiMessage = new DummyMessage('API'); - - $receiver = new DummyReceiver([[new Envelope($apiMessage)]]); - - $bus = $this->createMock(MessageBusInterface::class); - - $dispatcher = new EventDispatcher(); - $dispatcher->addSubscriber(new StopWorkerOnMessageLimitListener(1)); - - $worker = new Worker(['transport' => $receiver], $bus, $dispatcher); - $worker->run(); - - $gcStatus = gc_status(); - - $this->assertGreaterThan(0, $gcStatus['runs']); - } } class DummyQueueReceiver extends DummyReceiver implements QueueReceiverInterface diff --git a/src/Symfony/Component/Messenger/Worker.php b/src/Symfony/Component/Messenger/Worker.php index e8811228e7563..68510c33b34fc 100644 --- a/src/Symfony/Component/Messenger/Worker.php +++ b/src/Symfony/Component/Messenger/Worker.php @@ -117,8 +117,6 @@ public function run(array $options = []): void // this should prevent multiple lower priority receivers from // blocking too long before the higher priority are checked if ($envelopeHandled) { - gc_collect_cycles(); - break; } }