Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Security] Remove callable firewall listeners support #60879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

MatTheCat
Copy link
Contributor

@MatTheCat MatTheCat commented Jun 23, 2025

Q A
Branch? 8.0
Bug fix? no
New feature? no
Deprecations? no
Issues N/A
License MIT

Follow-up of #60614

Now that firewall listeners must implement FirewallListenerInterface, their traceable version’s stub can be their class name again.

@MatTheCat MatTheCat requested a review from chalasr as a code owner June 23, 2025 17:11
@carsonbot carsonbot added this to the 8.0 milestone Jun 23, 2025
@MatTheCat MatTheCat force-pushed the remove-callable-listeners branch 5 times, most recently from db3f2b4 to afe20ea Compare June 23, 2025 17:35
@carsonbot carsonbot changed the title Remove callable firewall listeners support [Security] Remove callable firewall listeners support Jun 23, 2025
@chalasr
Copy link
Member

chalasr commented Jun 23, 2025

There are some PHPDoc updates that were forgotten; should I open a PR against 6.4 for these?

Please yes

@nicolas-grekas
Copy link
Member

Please also update the corresponding changelog files

@MatTheCat MatTheCat force-pushed the remove-callable-listeners branch from afe20ea to 116995d Compare June 24, 2025 07:37
@MatTheCat MatTheCat force-pushed the remove-callable-listeners branch 3 times, most recently from afe20ea to fb7c051 Compare June 24, 2025 07:42
@MatTheCat MatTheCat force-pushed the remove-callable-listeners branch from fb7c051 to fcadbf0 Compare June 24, 2025 07:43
@nicolas-grekas
Copy link
Member

Thank you @MatTheCat.

@nicolas-grekas nicolas-grekas merged commit c935ea5 into symfony:8.0 Jun 24, 2025
8 of 9 checks passed
@MatTheCat MatTheCat deleted the remove-callable-listeners branch June 24, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants