[2.3] Improve preferred language detection #6928
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mweimerskirch you should add a unit test, and conform to http://symfony.com/doc/current/contributing/code/patches.html - it might also be good to check when this bug first appear and fix it there (ie 2.0 or 2.1). Thanks. |
|
@mweimerskirch it seems right, but as said @vicb, without any unit test, this wont be merged. |
fabpot
added a commit
that referenced
this pull request
Mar 18, 2013
This PR was squashed before being merged into the 2.1 branch (closes #7378). Commits ------- 17dc2ff [HttpRequest] fixes Request::getLanguages() bug Discussion ---------- [HttpRequest] fixes Request::getLanguages() bug This PR adds to suported languages the first segment of all compouds languages codes. When receiving `Accept-Language: en-us` header, accepted languages will now be `en, en_US`. This should not be a BC break as most browsers already send the long **and** short versions of language codes... but some dont. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #6928
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getPreferredLanguage does a simple intersect between the given languages and the ones from the request.
e.g. if you call getPreferredLanguage(array('fr', 'de', 'en')) and your Browser sends "en-US,en" as the accepted languages, the expected behaviour would be to have it return "en". This works most of the time. However, Safari (and possibly other browsers) only send the longer version (in the above example it would only send "en-us"), so getPreferredLanguage would not return "en" but the first result, which would be "fr".
This patch adds the shorter language code to the array of requested languages in order to fix this. I'm not sure if this patch is the best approach, so I'd appreciate feedback.