Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[TwigBridge] fixed trans twig extractor #7206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

[TwigBridge] fixed trans twig extractor #7206

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
94364da
[TwigBridge] added trans_default_domain + trans test
jfsimon Feb 27, 2013
11b7dbc
TwigBridge] added translation extractor's node visitors tests
jfsimon Feb 27, 2013
2f3d0e0
[TwigBridge] fixed node visitors priority & added extractor tests
jfsimon Feb 27, 2013
5a2c1c0
removed temp variable when compiling trans_default_domain to allow ot…
fabpot Feb 27, 2013
f5dd9c7
[TwigBridge] applied previous fix on node visitors
jfsimon Feb 27, 2013
0923e1d
[TwigBridge] added message extraction with invalid domain node test
jfsimon Feb 27, 2013
c032595
[TwigBridge] added support for named arguments to translation visitor
jfsimon Feb 28, 2013
e4be8e7
[TwigBridge] renamed private methods
jfsimon Feb 28, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[TwigBridge] added message extraction with invalid domain node test
  • Loading branch information
@jfsimon
jfsimon committed Feb 27, 2013
commit 0923e1d895fa1e25293386e901b9f7ff891c0cf9
17 changes: 17 additions & 0 deletions src/Symfony/Bridge/Twig/Tests/NodeVisitor/TranslationNodeVisitorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,23 @@ public function testMessagesExtraction(\Twig_Node $node, array $expectedMessages
$this->assertEquals($expectedMessages, $visitor->getMessages());
}

public function testMessageExtractionWithInvalidDomainNode()
{
$message = 'new key';

$node = new \Twig_Node_Expression_Filter(
new \Twig_Node_Expression_Constant($message, 0),
new \Twig_Node_Expression_Constant('trans', 0),
new \Twig_Node(array(
new \Twig_Node_Expression_Array(array(), 0),
new \Twig_Node_Expression_Name('variable', 0),
)),
0
);

$this->testMessagesExtraction($node, array(array($message, TranslationNodeVisitor::UNDEFINED_DOMAIN)));
}

public function getMessagesExtractionTestData()
{
$message = 'new key';
Expand Down