Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 183be7d

Browse files
committed
Removed the PR table example (this is now included by GitHub template)
1 parent 07edc04 commit 183be7d

File tree

1 file changed

+4
-43
lines changed

1 file changed

+4
-43
lines changed

contributing/code/patches.rst

Lines changed: 4 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -268,49 +268,10 @@ pull request message, like in:
268268
[Yaml] fixed something
269269
[Form] [Validator] [FrameworkBundle] added something
270270
271-
The pull request description must include the following checklist at the top
272-
to ensure that contributions may be reviewed without needless feedback
273-
loops and that your contributions can be included into Symfony as quickly as
274-
possible:
275-
276-
.. code-block:: text
277-
278-
| Q | A
279-
| ------------- | ---
280-
| Bug fix? | [yes|no]
281-
| New feature? | [yes|no]
282-
| BC breaks? | [yes|no]
283-
| Deprecations? | [yes|no]
284-
| Tests pass? | [yes|no]
285-
| Fixed tickets | [comma separated list of tickets fixed by the PR]
286-
| License | MIT
287-
| Doc PR | [The reference to the documentation PR if any]
288-
289-
An example submission could now look as follows:
290-
291-
.. code-block:: text
292-
293-
| Q | A
294-
| ------------- | ---
295-
| Bug fix? | no
296-
| New feature? | no
297-
| BC breaks? | no
298-
| Deprecations? | no
299-
| Tests pass? | yes
300-
| Fixed tickets | #12, #43
301-
| License | MIT
302-
| Doc PR | symfony/symfony-docs#123
303-
304-
The whole table must be included (do **not** remove lines that you think are
305-
not relevant). For simple typos, minor changes in the PHPDocs, or changes in
306-
translation files, use the shorter version of the check-list:
307-
308-
.. code-block:: text
309-
310-
| Q | A
311-
| ------------- | ---
312-
| Fixed tickets | [comma separated list of tickets fixed by the PR]
313-
| License | MIT
271+
The default pull request description contains a table which you must fill in
272+
with the appropriate answers. This ensures that contributions may be reviewed
273+
without needless feedback loops and that your contributions can be included into
274+
Symfony as quickly as possible:
314275

315276
Some answers to the questions trigger some more requirements:
316277

0 commit comments

Comments
 (0)