minor #19321 match parameter names with AbstractBundle (tacman)

javiereguiluz · javiereguiluz · commit 97b5ef11a03c · 2024-01-17T14:49:11.000+01:00
This PR was submitted for the 7.0 branch but it was merged into the 6.3 branch instead. Discussion ---------- match parameter names with AbstractBundle For consistency, the parameters should match AbstractBundle Commits ------- 6896b7e match parameter names with AbstractBundle
diff --git a/bundles/extension.rst b/bundles/extension.rst
@@ -127,18 +127,18 @@ method::
 
     class AcmeHelloBundle extends AbstractBundle
     {
-        public function loadExtension(array $config, ContainerConfigurator $containerConfigurator, ContainerBuilder $containerBuilder): void
+        public function loadExtension(array $config, ContainerConfigurator $container, ContainerBuilder $builder): void
         {
             // load an XML, PHP or Yaml file
-            $containerConfigurator->import('../config/services.xml');
+            $container->import('../config/services.xml');
 
             // you can also add or replace parameters and services
-            $containerConfigurator->parameters()
+            $container->parameters()
                 ->set('acme_hello.phrase', $config['phrase'])
             ;
 
             if ($config['scream']) {
-                $containerConfigurator->services()
+                $container->services()
                     ->get('acme_hello.printer')
                         ->class(ScreamingPrinter::class)
                 ;

Original file line number	Diff line number	Diff line change
`@@ -127,18 +127,18 @@ method::`
`127`	`127`
`128`	`128`	`class AcmeHelloBundle extends AbstractBundle`
`129`	`129`	`{`
`130`		`- public function loadExtension(array $config, ContainerConfigurator $containerConfigurator, ContainerBuilder $containerBuilder): void`
	`130`	`+ public function loadExtension(array $config, ContainerConfigurator $container, ContainerBuilder $builder): void`
`131`	`131`	`{`
`132`	`132`	`// load an XML, PHP or Yaml file`
`133`		`- $containerConfigurator->import('../config/services.xml');`
	`133`	`+ $container->import('../config/services.xml');`
`134`	`134`
`135`	`135`	`// you can also add or replace parameters and services`
`136`		`- $containerConfigurator->parameters()`
	`136`	`+ $container->parameters()`
`137`	`137`	`->set('acme_hello.phrase', $config['phrase'])`
`138`	`138`	`;`
`139`	`139`
`140`	`140`	`if ($config['scream']) {`
`141`		`- $containerConfigurator->services()`
	`141`	`+ $container->services()`
`142`	`142`	`->get('acme_hello.printer')`
`143`	`143`	`->class(ScreamingPrinter::class)`
`144`	`144`	`;`