Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WebProfilerBundle] Removed application name #10565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javiereguiluz opened this issue Oct 25, 2018 · 2 comments
Closed

[WebProfilerBundle] Removed application name #10565

javiereguiluz opened this issue Oct 25, 2018 · 2 comments

Comments

@javiereguiluz
Copy link
Member

symfony/symfony#28939

@TimoBakx
Copy link
Member

TimoBakx commented Dec 8, 2018

I don't think any changes are needed.

None of the removed twig variables are mentioned in the 4.2 documentation.

Deprecations were:

  • The Kernel::getRootDir() and the kernel.root_dir parameter have been deprecated

No references to the method or parameter found in the 4.2 documentation.

  • The KernelInterface::getName() and the kernel.name parameter have been deprecated

A deprecation notice is already present: https://github.com/symfony/symfony-docs/blob/master/reference/configuration/kernel.rst#kernel-name

  • Deprecated the first and second constructor argument of ConfigDataCollector

No references to ConfigDataCollector found in the 4.2 documentation.

  • Deprecated ConfigDataCollector::getApplicationName()

No references to this method found in the 4.2 documentation.

  • Deprecated ConfigDataCollector::getApplicationVersion()

No references to this method found in the 4.2 documentation.

@xabbuh
Copy link
Member

xabbuh commented Dec 22, 2018

let's close here then

@xabbuh xabbuh closed this as completed Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants