Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Validator] Support ICU timezones #11502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ro0NL opened this issue Apr 29, 2019 · 0 comments
Closed

[Validator] Support ICU timezones #11502

ro0NL opened this issue Apr 29, 2019 · 0 comments
Assignees
Labels
hasPR A Pull Request has already been submitted for this issue. Validator
Milestone

Comments

@ro0NL
Copy link
Contributor

ro0NL commented Apr 29, 2019

see symfony/symfony#31292

@javiereguiluz javiereguiluz added Validator Waiting Code Merge Docs for features pending to be merged labels Apr 30, 2019
fabpot added a commit to symfony/symfony that referenced this issue May 1, 2019
This PR was merged into the 4.3-dev branch.

Discussion
----------

[Validator] Allow intl timezones

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | ref #28836
| License       | MIT
| Doc PR        | symfony/symfony-docs#11502

This PR considers the ICU timezones (#28831) as valid, as well as the PHP ones.

Both can be used in `DateTimeZone`, but expired timezones cannot be used with `IntlTimeZone`. The `intlCompatibility` option ensures compatibility between both.

Practically this allows for both `UTC` and `Etc/UTC`, where the latter should be preferred. I.e. currently `Etc/UTC` is considered an invalid timezone ... which it's not.

Commits
-------

7294b59 [Validator] Allow intl timezones
@xabbuh xabbuh removed the Waiting Code Merge Docs for features pending to be merged label May 6, 2019
@xabbuh xabbuh added this to the 4.3 milestone May 6, 2019
@javiereguiluz javiereguiluz self-assigned this Jul 29, 2019
@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hasPR A Pull Request has already been submitted for this issue. Validator
Projects
None yet
Development

No branches or pull requests

3 participants