Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Smsapi - Make "from" optional #17893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabpot opened this issue Feb 10, 2023 · 1 comment
Closed

Smsapi - Make "from" optional #17893

fabpot opened this issue Feb 10, 2023 · 1 comment
Labels
hasPR A Pull Request has already been submitted for this issue. Notifier
Milestone
6.3

Comments

@fabpot
Copy link
Member

fabpot commented Feb 10, 2023

Q A
Feature PR symfony/symfony#49261
PR author(s) @szal1k
Merged in 6.3

We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.

To fix this issue, please create a PR against the 6.3 branch in the symfony-docs repository.

Thank you! 😄
@fabpot fabpot added this to the 6.3 milestone Feb 10, 2023
@SzymonKaminski SzymonKaminski mentioned this issue Feb 11, 2023
Merged
OskarStark added a commit that referenced this issue Feb 11, 2023
@OskarStark
minor #17895 [Notifier] from is optional in Smsapi since 6.3 (Szymo…
647da19 
…nKaminski)

This PR was merged into the 6.3 branch.

Discussion
----------

[Notifier] `from` is optional in Smsapi since 6.3

This PR aims to resolve #17893.
On a related note, would it be a good idea to put all optional parameters of DSNs in the table above in square brackets?

Commits
-------

2a34c8b [Notifier] `from` is optional in Smsapi since 6.3
@xabbuh xabbuh added hasPR A Pull Request has already been submitted for this issue. Notifier labels Feb 11, 2023
@xabbuh xabbuh closed this as completed Feb 11, 2023
@xabbuh
Copy link
Member

xabbuh commented Feb 11, 2023

fixed in #17895

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. Notifier
Projects
None yet
Milestone
6.3
Development

No branches or pull requests
2 participants
@fabpot @xabbuh