Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DoctrineBridge] deprecate doctrine schema subscribers in favor of list… #18006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolas-grekas opened this issue Mar 6, 2023 · 6 comments
Closed

[DoctrineBridge] deprecate doctrine schema subscribers in favor of list… #18006

nicolas-grekas opened this issue Mar 6, 2023 · 6 comments
Labels
DoctrineBridge
Milestone
6.3

Comments

@nicolas-grekas
Copy link
Member

Q A
Feature PR symfony/symfony#49610
PR author(s) @alli83
Merged in 6.3
@nicolas-grekas nicolas-grekas added this to the 6.3 milestone Mar 6, 2023
@alamirault
Copy link
Contributor

alamirault commented Mar 9, 2023 •
edited
Loading

I found no reference for the 3 deprecated subscribers in docs

@alli83
Copy link
Contributor

alli83 commented Mar 9, 2023 •
edited
Loading

@alamirault I'm sorry for the delay, I'm working on it.

@alamirault
Copy link
Contributor

Great ! It was just an observation of the existing 😄

@alli83
Copy link
Contributor

alli83 commented Mar 9, 2023 •
edited
Loading

I'am actually a little bit confused where it should be updated in Symfony-docs not seeing them already mentioned. Maybe more focused on why this change ?

@chalasr
Copy link
Member

chalasr commented Mar 9, 2023

Changing a subscriber into a listener does not change the final behavior, so if there is no direct reference to the deprecated classes then therés nothing to do and this can be closed.

@javiereguiluz
Copy link
Member

OK. Let's close this then. Thanks a lot @alli83 for checking this and thanks to the other reviewers too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DoctrineBridge
Projects
None yet
Milestone
6.3
Development

No branches or pull requests
6 participants
@javiereguiluz @nicolas-grekas @chalasr @alamirault @carsonbot @alli83