Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update the PR table in the contributing guide #6357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Mar 12, 2016 · 5 comments
Closed

Update the PR table in the contributing guide #6357

javiereguiluz opened this issue Mar 12, 2016 · 5 comments
Labels
Waiting feedback

Comments

@javiereguiluz
Copy link
Member

As pointed by @vladapopster, the contributing guide (http://symfony.com/doc/current/contributing/code/patches.html#make-a-pull-request) contains a PR table which is not updated to the latest one used in the Symfony repository (it lacks the Branch row for example).
@javiereguiluz javiereguiluz mentioned this issue Mar 12, 2016
Closed
@wouterj
Copy link
Member

wouterj commented Mar 12, 2016

Now we have PR templates on github, do we actually need to duplicate the template in the contributing docs? It seems like it can only get outdated and doesn't add anything more than saying "Fill in the table in the PR template."

@xabbuh
Copy link
Member

xabbuh commented Mar 13, 2016

I agree with Wouter. Let's just remove the table from the docs.

@javiereguiluz javiereguiluz mentioned this issue Mar 14, 2016
Merged
weaverryan added a commit that referenced this issue Mar 17, 2016
@weaverryan
minor #6365 Removed the PR table example (this is now included by Git…
a12bbd6 
…Hub template) (javiereguiluz)

This PR was merged into the 2.3 branch.

Discussion
----------

Removed the PR table example (this is now included by GitHub template)

This fixes #6357

Commits
-------

a6fe200 Removed the PR table example (this is now included by GitHub template)
@javiereguiluz
Copy link
Member Author

This can be closed as "fixed" because #6365 was merged. Thanks!

@mvar
Copy link
Contributor

mvar commented Oct 7, 2016

Are there any notes why Issue and Pull Request templates were removed? @wouterj wrote that "Now we have PR templates on github" but I can't see any. Same for the main Symfony repository.

@xabbuh
Copy link
Member

xabbuh commented Oct 7, 2016

@mvar At some point we decided that most of the time having to fill out a table is too cumbersome for simple documentation contributions and we wanted to further lower the burden to contribute to the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Waiting feedback
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@javiereguiluz @wouterj @mvar @xabbuh