Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Document the new kernel.controller_arguments event #6854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Aug 5, 2016 · 4 comments
Closed

Document the new kernel.controller_arguments event #6854

javiereguiluz opened this issue Aug 5, 2016 · 4 comments
Labels
actionable Clear and specific issues ready for anyone to take them.
Milestone
3.2

Comments

@javiereguiluz
Copy link
Member

@javiereguiluz javiereguiluz mentioned this issue Aug 5, 2016
Closed
@wouterj wouterj added this to the 3.1 milestone Aug 5, 2016
@wouterj wouterj added Missing Documentation actionable Clear and specific issues ready for anyone to take them. labels Aug 5, 2016
@mickaelandrieu
Copy link
Contributor

@javiereguiluz if I may ask, your previous PR sounds "good enough" to me: why did motivate you to close it ?

Mickaël

@javiereguiluz
Copy link
Member Author

@mickaelandrieu because Wouter and Stof comments made me realize that I was trying to document something that I don't fully understand. It needs more work.

@HeahDude HeahDude modified the milestones: 3.1, 3.2 Apr 15, 2017
@javiereguiluz
Copy link
Member Author

This is the only pending issue of the Symfony 3.2 milestone which I cannot fix myself. @stof, @iltar would you have some time to add docs for this feature or add some comment or example in this issue so I could try to write some docs? Thanks!

@ottaviano ottaviano mentioned this issue Nov 6, 2018
Closed
javiereguiluz added a commit that referenced this issue Apr 5, 2019
@javiereguiluz
minor #10640 Http kernel controller arguments (ottaviano)
0a21fa5 
This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes #10640).

Discussion
----------

Http kernel controller arguments

Hi,
I saw the issue #6854, and I can not write full & clear doc to describe the `kernel.controller_arguments` event.
But I think that it will be nice to have this event in the list of all Kernel events.

I fix the `kernel.finish_request` event description. This event is triggered after `kernel.response` event (not only for a sub-request).

Commits
-------

cd5fe5a Http kernel controller arguments
@javiereguiluz
Copy link
Member Author

Closing as fixed by #10640. The new docs can be seen in https://symfony.com/doc/current/reference/events.html#kernel-controller-arguments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them.
Projects
None yet
Milestone
3.2
Development

No branches or pull requests
4 participants
@javiereguiluz @wouterj @mickaelandrieu @HeahDude