Thanks to visit codestin.com
Credit goes to github.com

Skip to content

New Method: Kernel::getProjectDir() #7768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
weaverryan opened this issue Apr 7, 2017 · 2 comments
Closed

New Method: Kernel::getProjectDir() #7768

weaverryan opened this issue Apr 7, 2017 · 2 comments
Labels
hasPR A Pull Request has already been submitted for this issue. HttpKernel
Milestone
3.3

Comments

@weaverryan
Copy link
Member

See symfony/symfony#22315
@weaverryan weaverryan added this to the 3.3 milestone Apr 7, 2017
@fabpot fabpot mentioned this issue Apr 7, 2017
Merged
@javiereguiluz
Copy link
Member

Technically the change is minimal, but updating our docs to replace kernel.root_dir by kernel.project_dir would be too much. I propose this:

  • Document the Kernel::getProjectDir() method in 3.3 but don't change the rest of the docs.
  • For 4.0 docs, only use kernel.project_dir and never mention kernel.root_dir

@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Apr 15, 2017
@javiereguiluz javiereguiluz mentioned this issue Apr 15, 2017
Closed
@wouterj
Copy link
Member

wouterj commented Apr 19, 2017 •
edited
Loading

I don't agree with your proposal @javiereguiluz. I don't think something can be "too much". E.g. in 2.8, we changed all form types to use the FQCN. I think we should stick with our guide to not recommend usage of deprecated features.

So whenever we use kernel.root_dir and it's not a copy/paste example from the SE, I think we should use kernel.project_dir.

(this btw won't block #7810 from being merged, it can be done in another PR)

@xabbuh xabbuh mentioned this issue Apr 20, 2017
Merged
javiereguiluz added a commit that referenced this issue Apr 24, 2017
@javiereguiluz
minor #7829 replace kernel.root_dir with kernel.project_dir (xabbuh, …
6dc4742 
…javiereguiluz)

This PR was merged into the master branch.

Discussion
----------

replace kernel.root_dir with kernel.project_dir

see #7768

Commits
-------

3c0ba11 Fixed a path
b49da4a replace kernel.root_dir with kernel.project_dir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. HttpKernel
Projects
None yet
Milestone
3.3
Development

Successfully merging a pull request may close this issue.

Documented the new getProjectDir() method javiereguiluz/symfony-docs
4 participants
@javiereguiluz @weaverryan @wouterj @HeahDude