-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Update docs about class named services #8403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
…javiereguiluz) This PR was merged into the 3.4 branch. Discussion ---------- Docs for referencing tagged services in config See symfony/symfony#22200 Curious how it looks :) also a bit related to #8403 Commits ------- ed70659 Update tags.rst 2e5c87f Update tags.rst 564b5ea Update tags.rst a2fd23f Update tags.rst 000b801 Minor reword and fixes 0aaf48b Update tags.rst 71158f8 Update tags.rst 61c74da Update tags.rst da034d2 Docs for referencing tagged services in config
@ro0NL thanks for reporting this issue but I'm afraid I don't understand you. What should we do about this?
Thanks! |
Let me do a quick test this weekend, and i'll propose a PR for this page. If i recall correctly the first example should be: swift.smpt_transport: # the ID
class: Swift_SmtpTransport # the Class Only for namespaced classes using the class as ID value works: Ns\Some: ~ Using the leading Using the leading |
About the class attribute
So in terms of consistency and providing working example code, even prior to the versions mentioned above, i think we should leave out the leading About the service ID
In this case we should actually provide working example code across all docs. Thus only use variants without leading Hope this clarifies. Im not aware how many examples are affected actually :) |
Thanks for the explanation. As discussed in symfony/symfony#28006, let's not "pollute" the docs with these internal details ... and let's improve the error message shown by Symfony. Thanks! |
E.g. https://symfony.com/doc/current/service_container/tags.html
Talks about
The first-like variants wont work, and i also think we should avoid leading
\
in class attr. This might break any normalization check. Standard is no leading slash.See also symfony/symfony#24145
basically using poor-man namespacing by example makes your life hard.
The text was updated successfully, but these errors were encountered: