Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Security] Added target user to SwitchUserListener #9095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Jan 21, 2018 · 5 comments
Closed

[Security] Added target user to SwitchUserListener #9095

javiereguiluz opened this issue Jan 21, 2018 · 5 comments
Labels
hasPR A Pull Request has already been submitted for this issue. Security
Milestone
4.1

Comments

@javiereguiluz
Copy link
Member

This adds the target user to the SwitchUserListener's accessDecisionManager->decide() call as the $object parameter to give any registered voters extra information.

See symfony/symfony#25092
@javiereguiluz javiereguiluz added this to the 4.1 milestone Jan 21, 2018
@jwmickey
Copy link
Contributor

As the author of this new feature I have a working use-case and would like to contribute the docs. Should this be appended to the impersonating_user.html file or does it need it's own page?

@xabbuh
Copy link
Member

xabbuh commented Jan 29, 2018

I think the existing article is a good place to add this.

@jwmickey
Copy link
Contributor

I submitted a PR for an example: #9353

I pushed this to the master branch. Would that be why the platform.sh check was not created?

@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Feb 27, 2018
@xabbuh
Copy link
Member

xabbuh commented Feb 27, 2018

I don't think that is related. It happens from time to time that builds are not triggered on platform.sh. I guess we need to check the logs. But thanks for notifying us anyway. 👍

@javiereguiluz
Copy link
Member Author

Closing as fixed by #9353.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. Security
Projects
None yet
Milestone
4.1
Development

No branches or pull requests
3 participants
@javiereguiluz @jwmickey @xabbuh