Rename parameters in prependExtension methods #21616
Merged
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c67efbf to
afe76da
Compare
Member
|
Yes, let's fix this. We merged it in 6.4 and all the upper branches. Thanks Alexandre! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the prependExtension signature was not correct see : https://github.com/symfony/symfony/blob/v8.0.0/src/Symfony/Component/HttpKernel/Bundle/AbstractBundle.php#L34
I got the error after generating the
prependExtensionfunction, the parameters names were not fitting the body of the function (that I copy/pasted from the documentation).