Documented how to add or remove values of multi-valued attributes #9553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Apr 10, 2018
components/ldap.rst
Outdated
| @@ -129,6 +129,10 @@ delete existing ones:: | |||
| $entry = $result[0]; | |||
| $entry->setAttribute('email', array('[email protected]')); | |||
| $entityManager->update($entry); | |||
|
|
|||
| // Adding or removing values to a multi-valued attribute is more efficient than using update() | |||
| $entityManager->addAttributeValues($entry, 'telephoneNumber', ['+1.111.222.3333', '+1.222.333.4444']); | |||
There was a problem hiding this comment.
For consistency please us the long array notation here.
|
I would also add a .. versionadded:: 4.1
The ``addAttributeValues()`` and ``removeAttributeValues()`` methods
were introduced in Symfony 4.1. |
|
@xabbuh Done. |
xabbuh
reviewed
Apr 10, 2018
|
|
||
| // Removing an existing entry | ||
| $entityManager->remove(new Entry('cn=Test User,dc=symfony,dc=com')); | ||
|
|
||
| .. versionadded:: 4.1 | ||
| The ``addAttributeValues()`` and ``removeAttributeValues()`` methods | ||
| were introduced in Symfony 4.1. |
There was a problem hiding this comment.
I think we need a blank line after this paragraph to have it rendered correctly.
xabbuh
approved these changes
Apr 10, 2018
|
@jean-gui thanks for adding this missing docs. It was a nice first contribution to Symfony Docs! |
javiereguiluz
added a commit
that referenced
this pull request
Apr 16, 2018
…tributes (jean-gui) This PR was merged into the master branch. Discussion ---------- Documented how to add or remove values of multi-valued attributes Related to symfony/symfony#21856 <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 40df041 Documented how to add or remove values of multi-valued attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to symfony/symfony#21856