bug #6 Fix version validation rule to use full-matching (fivestar)

stof · stof · commit ecad998ee9e0 · 2014-10-21T10:14:25.000+02:00
This PR was squashed before being merged into the 1.0-dev branch (closes #6). Discussion ---------- Fix version validation rule to use full-matching Currently: ``` % symfony new blog/ a2.2.5 Downloading Symfony... [GuzzleHttp\Exception\ClientException] Client error response [url] http://get.symfony.com/Symfony_Standard_Vendors_a2.2.5.zip [status code] 403 [reason phrase] Forbidden new name [version] ``` After fixed: ``` % symfony new blog/ a2.2.5 [RuntimeException] The Symfony version should be 2.N.M, where N = 0..9 and M = 0..99 new name [version] ``` Commits ------- b0d17a8 Fix version validation rule to use full-matching
diff --git a/src/Symfony/Installer/NewCommand.php b/src/Symfony/Installer/NewCommand.php
@@ -46,7 +46,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         }
 
         $symfonyVersion = $input->getArgument('version');
-        if (!preg_match('/2\.\d\.\d+/', $symfonyVersion)) {
+        if (!preg_match('/^2\.\d\.\d+$/', $symfonyVersion)) {
             throw new \RuntimeException("The Symfony version should be 2.N.M, where N = 0..9 and M = 0..99");
         }
 

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`$symfonyVersion = $input->getArgument('version');`
`49`		`- if (!preg_match('/2\.\d\.\d+/', $symfonyVersion)) {`
	`49`	`+ if (!preg_match('/^2\.\d\.\d+$/', $symfonyVersion)) {`
`50`	`50`	`throw new \RuntimeException("The Symfony version should be 2.N.M, where N = 0..9 and M = 0..99");`
`51`	`51`	`}`
`52`	`52`