Fix format strings for deprecation notices

TysonAndre · TysonAndre · commit 23fd7aac70d9 · 2019-01-27T18:11:39.000-05:00
The `%c` conversion specifier expects an integer
(the value of the byte to print)

Detected via static analysis
diff --git a/IdentityTranslator.php b/IdentityTranslator.php
@@ -34,7 +34,7 @@ public function __construct(MessageSelector $selector = null)
         $this->selector = $selector;
 
         if (__CLASS__ !== \get_class($this)) {
-            @trigger_error(sprintf('Calling "%s()" is deprecated since Symfony 4.2.'), E_USER_DEPRECATED);
+            @trigger_error(sprintf('Calling "%s()" is deprecated since Symfony 4.2.', __METHOD__), E_USER_DEPRECATED);
         }
     }
 
@@ -45,7 +45,7 @@ public function __construct(MessageSelector $selector = null)
      */
     public function transChoice($id, $number, array $parameters = [], $domain = null, $locale = null)
     {
-        @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 4.2, use the trans() one instead with a "%count%" parameter.', __METHOD__), E_USER_DEPRECATED);
+        @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 4.2, use the trans() one instead with a "%%count%%" parameter.', __METHOD__), E_USER_DEPRECATED);
 
         if ($this->selector) {
             return strtr($this->selector->choose((string) $id, $number, $locale ?: $this->getLocale()), $parameters);
diff --git a/LoggingTranslator.php b/LoggingTranslator.php
@@ -64,7 +64,7 @@ public function trans($id, array $parameters = [], $domain = null, $locale = nul
      */
     public function transChoice($id, $number, array $parameters = [], $domain = null, $locale = null)
     {
-        @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 4.2, use the trans() one instead with a "%count%" parameter.', __METHOD__), E_USER_DEPRECATED);
+        @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 4.2, use the trans() one instead with a "%%count%%" parameter.', __METHOD__), E_USER_DEPRECATED);
 
         if ($this->translator instanceof TranslatorInterface) {
             $trans = $this->translator->trans($id, ['%count%' => $number] + $parameters, $domain, $locale);

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ public function __construct(MessageSelector $selector = null)`
`34`	`34`	`$this->selector = $selector;`
`35`	`35`
`36`	`36`	`if (__CLASS__ !== \get_class($this)) {`
`37`		`- @trigger_error(sprintf('Calling "%s()" is deprecated since Symfony 4.2.'), E_USER_DEPRECATED);`
	`37`	`+ @trigger_error(sprintf('Calling "%s()" is deprecated since Symfony 4.2.', __METHOD__), E_USER_DEPRECATED);`
`38`	`38`	`}`
`39`	`39`	`}`
`40`	`40`
`@@ -45,7 +45,7 @@ public function __construct(MessageSelector $selector = null)`
`45`	`45`	`*/`
`46`	`46`	`public function transChoice($id, $number, array $parameters = [], $domain = null, $locale = null)`
`47`	`47`	`{`
`48`		`- @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 4.2, use the trans() one instead with a "%count%" parameter.', __METHOD__), E_USER_DEPRECATED);`
	`48`	`+ @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 4.2, use the trans() one instead with a "%%count%%" parameter.', __METHOD__), E_USER_DEPRECATED);`
`49`	`49`
`50`	`50`	`if ($this->selector) {`
`51`	`51`	`return strtr($this->selector->choose((string) $id, $number, $locale ?: $this->getLocale()), $parameters);`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ public function trans($id, array $parameters = [], $domain = null, $locale = nul`
`64`	`64`	`*/`
`65`	`65`	`public function transChoice($id, $number, array $parameters = [], $domain = null, $locale = null)`
`66`	`66`	`{`
`67`		`- @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 4.2, use the trans() one instead with a "%count%" parameter.', __METHOD__), E_USER_DEPRECATED);`
	`67`	`+ @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 4.2, use the trans() one instead with a "%%count%%" parameter.', __METHOD__), E_USER_DEPRECATED);`
`68`	`68`
`69`	`69`	`if ($this->translator instanceof TranslatorInterface) {`
`70`	`70`	`$trans = $this->translator->trans($id, ['%count%' => $number] + $parameters, $domain, $locale);`