-
-
Notifications
You must be signed in to change notification settings - Fork 356
[StimulusBundle] Rename bootstrap.js to bootstrap-stimulus.js #1278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Had at work the same « wtf » moment with coworker when i introduced this package /file boot_ux.js / init_ux.js / boot_app.js ? naming can be « improved » to dissociate with bootstrap framework indeed :) |
This is still confusing to me too. If others face the same issue, we could revisit this and consider a name change. |
This is very "webpack-like".. If we can find a way to do this with no BC / generating frustration, i'm all in to rename.... but i'd even think we could entirely remove it (and merge within app.js) WDYT ? |
I quite like the idea of moving it into app.js. If we were to do that, what about also renaming the app var to application, so it'd be more consistent with stimulus-components and the hotwired documentation
that is
I think the recipe should include
or false, but either way, make it explicit. One potential downside to embedding the code in app.js is that if someone were to create a command that installs stimulus components, it'd be easier to automate initializing it. That is
would install it as well.
|
Thank you for this issue. |
Could I get an answer? If I do not hear anything I will assume this issue is resolved or abandoned. Please get back to me <3 |
Hey, I didn't hear anything so I'm going to close it. Feel free to comment if this is still relevant, I can always reopen! |
Thank you for this issue. |
Not something we can do for now, let's reopen the debate in 3.0 |
Given the ubiquity of the bootstrap framework, I find it confusing to have the script to integrating stimulus also called bootstrap.js.
My app.js usually looks like this
It's so easy to get these confused, I think bootstrap-stimulus.js would be clearer. Also, it's generated by the recipe, so it's not even like its saving typing.
The text was updated successfully, but these errors were encountered: