Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[StimulusBundle] Rename bootstrap.js to bootstrap-stimulus.js #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tacman opened this issue Nov 14, 2023 · 9 comments
Closed

[StimulusBundle] Rename bootstrap.js to bootstrap-stimulus.js #1278

tacman opened this issue Nov 14, 2023 · 9 comments
Labels

Comments

@tacman
Copy link
Contributor

tacman commented Nov 14, 2023

Given the ubiquity of the bootstrap framework, I find it confusing to have the script to integrating stimulus also called bootstrap.js.

My app.js usually looks like this

// stimulus
import './bootstrap.js';

// bootstrap 5
import 'bootstrap'; // bootstrap javascript
import 'bootstrap/dist/css/bootstrap.min.css'

It's so easy to get these confused, I think bootstrap-stimulus.js would be clearer. Also, it's generated by the recipe, so it's not even like its saving typing.

@94noni
Copy link
Contributor

94noni commented Jan 5, 2024

Had at work the same « wtf » moment with coworker when i introduced this package /file

boot_ux.js / init_ux.js / boot_app.js ?

naming can be « improved » to dissociate with bootstrap framework indeed :)

@javiereguiluz
Copy link
Member

This is still confusing to me too.

If others face the same issue, we could revisit this and consider a name change.

@smnandre
Copy link
Member

smnandre commented Apr 9, 2024

This is very "webpack-like"..

If we can find a way to do this with no BC / generating frustration, i'm all in to rename.... but i'd even think we could entirely remove it (and merge within app.js)

WDYT ?

@tacman
Copy link
Contributor Author

tacman commented Apr 9, 2024

I quite like the idea of moving it into app.js. If we were to do that, what about also renaming the app var to application, so it'd be more consistent with stimulus-components and the hotwired documentation

that is

import { Application } from '@hotwired/stimulus'

const application = Application.start()

I think the recipe should include

application.debug=true;

or false, but either way, make it explicit.

One potential downside to embedding the code in app.js is that if someone were to create a command that installs stimulus components, it'd be easier to automate initializing it. That is

bin/console importmap:require-stimulus timeago
# same as 
bin/console importmap:require stimulus-timeago
cat assets/stimulus-bootstrap.js

would install it as well.

import { startStimulusApp } from '@symfony/stimulus-bundle';
import Timeago from 'stimulus-timeago'

const application = startStimulusApp();
application.debug=true;
application.register('timeago', Timeago);

@carsonbot
Copy link

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

@carsonbot
Copy link

Could I get an answer? If I do not hear anything I will assume this issue is resolved or abandoned. Please get back to me <3

@carsonbot
Copy link

Hey,

I didn't hear anything so I'm going to close it. Feel free to comment if this is still relevant, I can always reopen!

@carsonbot
Copy link

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

@smnandre
Copy link
Member

Not something we can do for now, let's reopen the debate in 3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants