Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Directory structure consistency #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BafS opened this issue Sep 16, 2022 · 2 comments · Fixed by #547
Closed

Directory structure consistency #463

BafS opened this issue Sep 16, 2022 · 2 comments · Fixed by #547
Labels
Bug Bug Fix

Comments

@BafS
Copy link

BafS commented Sep 16, 2022

Some UX bundles are using the src/ folder to have the php logic (eg. https://github.com/symfony/ux/tree/2.x/src/Autocomplete) and some are not (eg. https://github.com/symfony/ux/tree/2.x/src/Chartjs).

As discussed in symfony/symfony-docs#15881 it would be great to be consistent, especially in the same repository.

The documentation got updated recently (https://symfony.com/doc/current/bundles.html#bundle-directory-structure and https://symfony.com/doc/current/bundles/best_practices.html#directory-structure) and the current best practice is to have the php logic under src/.
@weaverryan
Copy link
Member

Yes, I think we should probably move things around to follow the convention of using src/ as we've done in Autocomplete, and a few other packages. Consistency is super important in a mono-repo like this.

@weaverryan weaverryan added the Bug Bug Fix label Sep 19, 2022
@kbond
Copy link
Member

kbond commented Sep 19, 2022

We've discussed moving LiveComponent/src/Resources/* to LiveComponent/(root) but I believe the routing config would be a BC break.

@weaverryan weaverryan mentioned this issue Nov 12, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] All Package directory restructure weaverryan/ux
3 participants
@weaverryan @kbond @BafS