Thanks to visit codestin.com
Credit goes to github.com

Skip to content

split into symfony-cmf/chain-router and symfony-cmf/dynamic-router #274

@dbu

Description

@dbu

splitting this into 2 repositories would make the purpose of each repository clearer. the chain router is only a few classes, and shares no code with the dynamic router. this would be a clear benefit for users only wanting the chain router. (most people using the dynamic router probably also want to use chain router to be able to still use configured routing in addition to dynamic)

questions:

  • should we keep the namespace the same? that would mean that there is a risk that if we accidentally add a class with the same FQN in both repositories, one would hide the other. if we change the namespace, it will be a bit more annoying to upgrade for consumers.
  • should the routing bundle depend on both components? or do we also split the bundle? i tend to have the bundle depend on both.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions