You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 16, 2021. It is now read-only.
(1) and (3) are especially pretty hard to solve using the extractors.
I think we should go in a complete new direction for 1.1, however that can make things more complicated. I don't know if that's really welcome, since this bundle is pretty nice because it's not complicated.
Using Mappings
My idea was to use mappings instead of extractors. Instead of implementing some interfaces and introducing some wrapper methods which just call other functions, we should have a way to "map" some values of the document to SeoMetadata.
This can be done using the JmsSerializer. Some examples:
Current Issues
We are having 4 issues with the current Extractors mechanism:
(1) and (3) are especially pretty hard to solve using the extractors.
I think we should go in a complete new direction for 1.1, however that can make things more complicated. I don't know if that's really welcome, since this bundle is pretty nice because it's not complicated.
Using Mappings
My idea was to use mappings instead of extractors. Instead of implementing some interfaces and introducing some wrapper methods which just call other functions, we should have a way to "map" some values of the document to SeoMetadata.
This can be done using the JmsSerializer. Some examples:
Of course, we should also support Yaml and Xml mappings and mappings for methods. For instance:
Support Custom Data
Then we can also fix #131 by using a generic "Meta" mapping for custom meta values:
Keeping BC
Of course, we should be BC. So we should keep supporting the extractors, but deprecate it.
replaces #118