Disallow right child from being iterator of dict

ksunden · ksunden · commit d19e475d6fad · 2023-04-05T17:27:05.000-05:00
diff --git a/cycler/__init__.py b/cycler/__init__.py
@@ -150,7 +150,7 @@ def __call__(self):
     def __init__(
         self,
         left: Cycler[K, V] | Iterable[dict[K, V]] | None,
-        right: Cycler[K, V] | Iterable[dict[K, V]] | None = None,
+        right: Cycler[K, V] | None = None,
         op: Any = None,
     ):
         """
@@ -170,13 +170,9 @@ def __init__(
             self._left = []
 
         if isinstance(right, Cycler):
-            self._right: Cycler[K, V] | list[dict[K, V]] | None = Cycler(
+            self._right: Cycler[K, V] | None = Cycler(
                 right._left, right._right, right._op
             )
-        elif right is not None:
-            # Need to copy the dictionary or else that will be a residual
-            # mutable that could lead to strange errors
-            self._right = [copy.copy(v) for v in right]
         else:
             self._right = None
 
@@ -214,11 +210,7 @@ def change_key(self, old: K, new: K) -> None:
         self._keys.remove(old)
         self._keys.add(new)
 
-        if (
-            self._right is not None
-            and isinstance(self._right, Cycler)
-            and old in self._right.keys
-        ):
+        if self._right is not None and old in self._right.keys:
             self._right.change_key(old, new)
 
         # self._left should always be non-None
diff --git a/test_cycler.py b/test_cycler.py
@@ -289,10 +289,10 @@ def test_cycler_exceptions():
     pytest.raises(TypeError, cycler, 'c', 'rgb', 'lw', range(3))
 
 
-def test_starange_init():
+def test_strange_init():
     c = cycler('r', 'rgb')
     c2 = cycler('lw', range(3))
-    cy = Cycler(list(c), list(c2), zip)
+    cy = Cycler(list(c), c2, zip)
     assert cy == c + c2
 
 
