Do not write to stderr

manohms · manohms · commit afd2d34fcb7d · 2016-10-12T10:27:05.000+02:00
Log message with error level instead of writing to stderr.
Stderr may not be available on embedded systems.
It is better to send the messages to the logging framework.
diff --git a/src/main/java/de/taimos/gpsd4java/backend/LegacyResultParser.java b/src/main/java/de/taimos/gpsd4java/backend/LegacyResultParser.java
@@ -338,7 +338,7 @@ private IGPSObject parseSUBFRAME(final JSONObject json) throws ParseException {
 		} else if (json.has(IONOObject.NAME)) {
 			subframe.setIono((IONOObject) this.parse(json.optJSONObject(IONOObject.NAME)));
 		} else {
-			System.err.println("Unknown subframe: " + json.toString());
+			AbstractResultParser.LOG.error("Unknown subframe: {}", json.toString());
 		}
 		gps = subframe;
 		return gps;
diff --git a/src/main/java/de/taimos/gpsd4java/backend/ResultParser.java b/src/main/java/de/taimos/gpsd4java/backend/ResultParser.java
@@ -339,7 +339,7 @@ private IGPSObject parseSUBFRAME(final JSONObject json) throws ParseException {
 		} else if (json.has(IONOObject.NAME)) {
 			subframe.setIono((IONOObject) this.parse(json.optJSONObject(IONOObject.NAME)));
 		} else {
-			System.err.println("Unknown subframe: " + json.toString());
+			AbstractResultParser.LOG.error("Unknown subframe: {}", json.toString());
 		}
 		gps = subframe;
 		return gps;

Original file line number	Diff line number	Diff line change
`@@ -338,7 +338,7 @@ private IGPSObject parseSUBFRAME(final JSONObject json) throws ParseException {`
`338`	`338`	`} else if (json.has(IONOObject.NAME)) {`
`339`	`339`	`subframe.setIono((IONOObject) this.parse(json.optJSONObject(IONOObject.NAME)));`
`340`	`340`	`} else {`
`341`		`- System.err.println("Unknown subframe: " + json.toString());`
	`341`	`+ AbstractResultParser.LOG.error("Unknown subframe: {}", json.toString());`
`342`	`342`	`}`
`343`	`343`	`gps = subframe;`
`344`	`344`	`return gps;`
Original file line number	Diff line number	Diff line change
`@@ -339,7 +339,7 @@ private IGPSObject parseSUBFRAME(final JSONObject json) throws ParseException {`
`339`	`339`	`} else if (json.has(IONOObject.NAME)) {`
`340`	`340`	`subframe.setIono((IONOObject) this.parse(json.optJSONObject(IONOObject.NAME)));`
`341`	`341`	`} else {`
`342`		`- System.err.println("Unknown subframe: " + json.toString());`
	`342`	`+ AbstractResultParser.LOG.error("Unknown subframe: {}", json.toString());`
`343`	`343`	`}`
`344`	`344`	`gps = subframe;`
`345`	`345`	`return gps;`