chore(deps): update dependency eslint to v9 (v2) (#1424)

renovate[bot] · FabianLars · web-flow · commit a2eb3a6e4368 · 2024-06-03T21:04:13.000+02:00
* chore(deps): update dependency eslint to v9

* flat config

* license header

* rebuild

---------

Co-authored-by: renovate[bot] &lt;29139614+renovate[bot]@users.noreply.github.com&gt;
Co-authored-by: FabianLars &lt;fabianlars@fabianlars.de&gt;
diff --git a/.eslintignore b/.eslintignore
diff --git a/.eslintrc.json b/.eslintrc.json
diff --git a/eslint.config.js b/eslint.config.js
@@ -0,0 +1,36 @@
+// Copyright 2019-2023 Tauri Programme within The Commons Conservancy
+// SPDX-License-Identifier: Apache-2.0
+// SPDX-License-Identifier: MIT
+
+import eslint from "@eslint/js";
+import eslintConfigPrettier from "eslint-config-prettier";
+import eslintPluginSecurity from "eslint-plugin-security";
+import tseslint from "typescript-eslint";
+
+export default tseslint.config(
+  {
+    ignores: [
+      "**/target",
+      "**/node_modules",
+      "**/examples",
+      "**/dist",
+      "**/dist-js",
+      "**/build",
+      "**/api-iife.js",
+      "**/init-iife.js",
+      "**/init.js",
+      "**/rollup.config.js",
+      ".scripts",
+      "eslint.config.js",
+    ],
+  },
+  eslint.configs.recommended,
+  eslintConfigPrettier,
+  eslintPluginSecurity.configs.recommended,
+  ...tseslint.configs.recommendedTypeChecked,
+  {
+    languageOptions: {
+      parserOptions: { project: true, tsconfigRootDir: import.meta.dirname },
+    },
+  },
+);
diff --git a/package.json b/package.json
@@ -10,22 +10,20 @@
     "format-check": "prettier --check \"./**/*.{cjs,mjs,js,jsx,mts,ts,tsx,html,css,json}\" --ignore-path .prettierignore"
   },
   "devDependencies": {
+    "@eslint/js": "9.4.0",
     "@rollup/plugin-node-resolve": "15.2.3",
     "@rollup/plugin-terser": "0.4.4",
     "@rollup/plugin-typescript": "11.1.6",
-    "@typescript-eslint/eslint-plugin": "7.11.0",
-    "@typescript-eslint/parser": "7.11.0",
+    "@types/eslint__js": "8.42.3",
     "covector": "^0.11.0",
-    "eslint": "8.57.0",
+    "eslint": "9.4.0",
     "eslint-config-prettier": "9.1.0",
-    "eslint-plugin-import": "2.29.1",
-    "eslint-plugin-n": "17.7.0",
-    "eslint-plugin-promise": "6.2.0",
     "eslint-plugin-security": "3.0.0",
     "prettier": "3.3.0",
     "rollup": "4.18.0",
     "tslib": "2.6.2",
-    "typescript": "5.4.5"
+    "typescript": "5.4.5",
+    "typescript-eslint": "rc-v8"
   },
   "resolutions": {
     "semver": ">=7.5.2",
diff --git a/plugins/dialog/guest-js/index.ts b/plugins/dialog/guest-js/index.ts
@@ -163,7 +163,6 @@ type OpenDialogReturn<T extends OpenDialogOptions> = T["directory"] extends true
  * @since 2.0.0
  */
 async function open<T extends OpenDialogOptions>(
-  // eslint-disable-next-line @typescript-eslint/consistent-type-assertions
   options: T = {} as T,
 ): Promise<OpenDialogReturn<T>> {
   if (typeof options === "object") {
diff --git a/plugins/fs/guest-js/index.ts b/plugins/fs/guest-js/index.ts
@@ -777,7 +777,6 @@ async function readTextFileLines(
       if (done) this.rid = null;
 
       return {
-        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
         value: done ? "" : line!,
         done,
       };
diff --git a/plugins/http/guest-js/index.ts b/plugins/http/guest-js/index.ts
@@ -141,6 +141,7 @@ export async function fetch(
         ? headers
         : Object.entries(headers);
 
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
   const mappedHeaders: Array<[string, string]> = headersArray.map(
     ([name, val]) => [
       name,
diff --git a/plugins/notification/guest-js/index.ts b/plugins/notification/guest-js/index.ts
@@ -364,10 +364,8 @@ async function requestPermission(): Promise<Permission> {
  */
 function sendNotification(options: Options | string): void {
   if (typeof options === "string") {
-    // eslint-disable-next-line no-new
     new window.Notification(options);
   } else {
-    // eslint-disable-next-line no-new
     new window.Notification(options.title, options);
   }
 }
diff --git a/plugins/notification/guest-js/init.ts b/plugins/notification/guest-js/init.ts
@@ -57,11 +57,12 @@ import type { Options } from "./index";
 
   // @ts-expect-error unfortunately we can't implement the whole type, so we overwrite it with our own version
   window.Notification = function (title, options) {
-    // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
     const opts = options || {};
     void sendNotification(
       // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
       Object.assign(opts, {
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
         title,
       }),
     );
@@ -77,6 +78,7 @@ import type { Options } from "./index";
       if (!permissionSettable) {
         throw new Error("Readonly property");
       }
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
       permissionValue = v;
     },
   });
diff --git a/plugins/shell/guest-js/index.ts b/plugins/shell/guest-js/index.ts
@@ -171,7 +171,6 @@ class EventEmitter<E extends Record<string, any>> {
   ): this {
     const wrapper = (arg: E[typeof eventName]): void => {
       this.removeListener(eventName, wrapper);
-      // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
       listener(arg);
     };
     return this.addListener(eventName, wrapper);
@@ -204,9 +203,8 @@ class EventEmitter<E extends Record<string, any>> {
    * @since 2.0.0
    */
   removeAllListeners<N extends keyof E>(event?: N): this {
-    // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions
     if (event) {
-      // eslint-disable-next-line @typescript-eslint/no-dynamic-delete,security/detect-object-injection
+      // eslint-disable-next-line security/detect-object-injection
       delete this.eventListeners[event];
     } else {
       // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
@@ -226,9 +224,8 @@ class EventEmitter<E extends Record<string, any>> {
    */
   emit<N extends keyof E>(eventName: N, arg: E[typeof eventName]): boolean {
     if (eventName in this.eventListeners) {
-      // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment,security/detect-object-injection
+      // eslint-disable-next-line security/detect-object-injection
       const listeners = this.eventListeners[eventName];
-      // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
       for (const listener of listeners) listener(arg);
       return true;
     }
diff --git a/plugins/updater/api-iife.js b/plugins/updater/api-iife.js
diff --git a/plugins/updater/guest-js/index.ts b/plugins/updater/guest-js/index.ts
@@ -72,7 +72,7 @@ class Update extends Resource {
   /** Install downloaded updater package */
   async install(): Promise<void> {
     if (!this.downloadedBytes) {
-      throw "Update.install called before Update.download";
+      throw new Error("Update.install called before Update.download");
     }
 
     await invoke("plugin:updater|install", {
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml

Original file line number	Diff line number	Diff line change
`@@ -364,10 +364,8 @@ async function requestPermission(): Promise<Permission> {`
`364`	`364`	`*/`
`365`	`365`	`function sendNotification(options: Options \| string): void {`
`366`	`366`	`if (typeof options === "string") {`
`367`		`- // eslint-disable-next-line no-new`
`368`	`367`	`new window.Notification(options);`
`369`	`368`	`} else {`
`370`		`- // eslint-disable-next-line no-new`
`371`	`369`	`new window.Notification(options.title, options);`
`372`	`370`	`}`
`373`	`371`	`}`