fix(events): Don't emit events for inputs that already have filled value attributes

tbosch · tbosch · commit e6bf44b2390c · 2014-02-06T11:57:41.000-08:00
Related to #2
diff --git a/src/autofill-event.js b/src/autofill-event.js
@@ -25,6 +25,11 @@
   });
 
   window.document.addEventListener('DOMContentLoaded', function() {
+    // mark all values that are present when the DOM is ready.
+    // We don't need to trigger a change event here,
+    // as js libs start with those values already being set!
+    forEach(document.getElementsByTagName('input'), markValue);
+
     // The timeout is needed for Chrome as it auto fills
     // login forms some time after DOMContentLoaded!
     window.setTimeout(function() {
@@ -48,6 +53,14 @@
   }
 
   function valueMarked(el) {
+    if (! ("$$currentValue" in el) ) {
+      // First time we see an element we take it's value attribute
+      // as real value. This might have been filled in the backend,
+      // ...
+      // Note: it's important to not use the value property here!
+      el.$$currentValue = el.getAttribute('value');
+    }
+
     var val = el.value,
          $$currentValue = el.$$currentValue;
     if (!val && !$$currentValue) {
@@ -114,4 +127,6 @@
     element.dispatchEvent(event);
   }
 
+
+
 })(window);
diff --git a/test/unit/autofill-eventSpec.js b/test/unit/autofill-eventSpec.js
@@ -92,6 +92,20 @@ describe('check other inputs when one input fires a blur event', function() {
         expect(input[0].changeEventCount).toBeUndefined();
       });
 
+    });
+
+    describe('misc', function() {
+      it('should not fire for untouched inputs with empty value', function() {
+        input.checkAndTriggerAutoFillEvent();
+        expect(input[0].changeEventCount).toBeUndefined();
+      });
+
+      it('should not fire if inputs are added with predefined value', function() {
+        container.append('<input type="text" value="test">');
+        var newInput = container.children().eq(1);
+        newInput.checkAndTriggerAutoFillEvent();
+        expect(newInput[0].changeEventCount).toBeUndefined();
+      });
 
     });
 
