From 0e8fdb6744ae78ad6103f733f1bdc21833b22300 Mon Sep 17 00:00:00 2001 From: Dan Davison Date: Mon, 16 Sep 2024 16:54:31 -0400 Subject: [PATCH 1/3] Move signals-queries into message-passing --- .../signals-queries-cancellation}/.eslintignore | 0 .../signals-queries-cancellation}/.eslintrc.js | 0 .../signals-queries-cancellation}/.gitignore | 0 .../signals-queries-cancellation}/.npmrc | 0 .../signals-queries-cancellation}/.nvmrc | 0 .../signals-queries-cancellation}/.post-create | 0 .../signals-queries-cancellation}/.prettierignore | 0 .../signals-queries-cancellation}/.prettierrc | 0 .../signals-queries-cancellation}/README.md | 0 .../signals-queries-cancellation}/package.json | 0 .../signals-queries-cancellation}/src/cancel-workflow.ts | 0 .../signals-queries-cancellation}/src/query-workflow.ts | 0 .../signals-queries-cancellation}/src/signal-workflow.ts | 0 .../signals-queries-cancellation}/src/start-workflow.ts | 0 .../signals-queries-cancellation}/src/worker.ts | 0 .../signals-queries-cancellation}/src/workflows.ts | 0 .../signals-queries-cancellation}/tsconfig.json | 0 17 files changed, 0 insertions(+), 0 deletions(-) rename {signals-queries => message-passing/signals-queries-cancellation}/.eslintignore (100%) rename {signals-queries => message-passing/signals-queries-cancellation}/.eslintrc.js (100%) rename {signals-queries => message-passing/signals-queries-cancellation}/.gitignore (100%) rename {signals-queries => message-passing/signals-queries-cancellation}/.npmrc (100%) rename {signals-queries => message-passing/signals-queries-cancellation}/.nvmrc (100%) rename {signals-queries => message-passing/signals-queries-cancellation}/.post-create (100%) rename {signals-queries => message-passing/signals-queries-cancellation}/.prettierignore (100%) rename {signals-queries => message-passing/signals-queries-cancellation}/.prettierrc (100%) rename {signals-queries => message-passing/signals-queries-cancellation}/README.md (100%) rename {signals-queries => message-passing/signals-queries-cancellation}/package.json (100%) rename {signals-queries => message-passing/signals-queries-cancellation}/src/cancel-workflow.ts (100%) rename {signals-queries => message-passing/signals-queries-cancellation}/src/query-workflow.ts (100%) rename {signals-queries => message-passing/signals-queries-cancellation}/src/signal-workflow.ts (100%) rename {signals-queries => message-passing/signals-queries-cancellation}/src/start-workflow.ts (100%) rename {signals-queries => message-passing/signals-queries-cancellation}/src/worker.ts (100%) rename {signals-queries => message-passing/signals-queries-cancellation}/src/workflows.ts (100%) rename {signals-queries => message-passing/signals-queries-cancellation}/tsconfig.json (100%) diff --git a/signals-queries/.eslintignore b/message-passing/signals-queries-cancellation/.eslintignore similarity index 100% rename from signals-queries/.eslintignore rename to message-passing/signals-queries-cancellation/.eslintignore diff --git a/signals-queries/.eslintrc.js b/message-passing/signals-queries-cancellation/.eslintrc.js similarity index 100% rename from signals-queries/.eslintrc.js rename to message-passing/signals-queries-cancellation/.eslintrc.js diff --git a/signals-queries/.gitignore b/message-passing/signals-queries-cancellation/.gitignore similarity index 100% rename from signals-queries/.gitignore rename to message-passing/signals-queries-cancellation/.gitignore diff --git a/signals-queries/.npmrc b/message-passing/signals-queries-cancellation/.npmrc similarity index 100% rename from signals-queries/.npmrc rename to message-passing/signals-queries-cancellation/.npmrc diff --git a/signals-queries/.nvmrc b/message-passing/signals-queries-cancellation/.nvmrc similarity index 100% rename from signals-queries/.nvmrc rename to message-passing/signals-queries-cancellation/.nvmrc diff --git a/signals-queries/.post-create b/message-passing/signals-queries-cancellation/.post-create similarity index 100% rename from signals-queries/.post-create rename to message-passing/signals-queries-cancellation/.post-create diff --git a/signals-queries/.prettierignore b/message-passing/signals-queries-cancellation/.prettierignore similarity index 100% rename from signals-queries/.prettierignore rename to message-passing/signals-queries-cancellation/.prettierignore diff --git a/signals-queries/.prettierrc b/message-passing/signals-queries-cancellation/.prettierrc similarity index 100% rename from signals-queries/.prettierrc rename to message-passing/signals-queries-cancellation/.prettierrc diff --git a/signals-queries/README.md b/message-passing/signals-queries-cancellation/README.md similarity index 100% rename from signals-queries/README.md rename to message-passing/signals-queries-cancellation/README.md diff --git a/signals-queries/package.json b/message-passing/signals-queries-cancellation/package.json similarity index 100% rename from signals-queries/package.json rename to message-passing/signals-queries-cancellation/package.json diff --git a/signals-queries/src/cancel-workflow.ts b/message-passing/signals-queries-cancellation/src/cancel-workflow.ts similarity index 100% rename from signals-queries/src/cancel-workflow.ts rename to message-passing/signals-queries-cancellation/src/cancel-workflow.ts diff --git a/signals-queries/src/query-workflow.ts b/message-passing/signals-queries-cancellation/src/query-workflow.ts similarity index 100% rename from signals-queries/src/query-workflow.ts rename to message-passing/signals-queries-cancellation/src/query-workflow.ts diff --git a/signals-queries/src/signal-workflow.ts b/message-passing/signals-queries-cancellation/src/signal-workflow.ts similarity index 100% rename from signals-queries/src/signal-workflow.ts rename to message-passing/signals-queries-cancellation/src/signal-workflow.ts diff --git a/signals-queries/src/start-workflow.ts b/message-passing/signals-queries-cancellation/src/start-workflow.ts similarity index 100% rename from signals-queries/src/start-workflow.ts rename to message-passing/signals-queries-cancellation/src/start-workflow.ts diff --git a/signals-queries/src/worker.ts b/message-passing/signals-queries-cancellation/src/worker.ts similarity index 100% rename from signals-queries/src/worker.ts rename to message-passing/signals-queries-cancellation/src/worker.ts diff --git a/signals-queries/src/workflows.ts b/message-passing/signals-queries-cancellation/src/workflows.ts similarity index 100% rename from signals-queries/src/workflows.ts rename to message-passing/signals-queries-cancellation/src/workflows.ts diff --git a/signals-queries/tsconfig.json b/message-passing/signals-queries-cancellation/tsconfig.json similarity index 100% rename from signals-queries/tsconfig.json rename to message-passing/signals-queries-cancellation/tsconfig.json From bfc6b9c77d74f3269a533371361056d1b5fd36d1 Mon Sep 17 00:00:00 2001 From: Dan Davison Date: Mon, 16 Sep 2024 16:57:26 -0400 Subject: [PATCH 2/3] Update index --- README.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 3634ac2f..b0d4dab2 100644 --- a/README.md +++ b/README.md @@ -107,12 +107,13 @@ and you'll be given the list of sample options. #### Workflow APIs - **Timers**: - - The [**progress example**](./timer-progress) demonstrates how to use the `sleep` function from `@temporalio/workflow`. - - [**Timer Examples**](./timer-examples): + - [**Timer**](./timer-examples): - Send a notification to the customer if their order is taking longer than expected (using a `Promise.race` between the order activity and `sleep`). - Create an `UpdatableTimer` that can be slept on, and at the same time, have its duration updated via Signals. -- **Signals and Triggers**: - - The [**Signals and Queries example**](https://github.com/temporalio/samples-typescript/tree/main/signals-queries) demonstrates the usage of Signals, Queries, and Workflow Cancellation. + - [**Timer Progress**](./timer-progress): demonstrates how to use the `sleep` function from `@temporalio/workflow`. +- **Message-passing**: + - [**Introduction**](https://github.com/temporalio/samples-typescript/tree/main/message-passing/introduction): an introduction to Query, Signal, and Update. + - [**Cancellation**](https://github.com/temporalio/samples-typescript/tree/main/message-passing/signals-queries-cancellation) demonstrates the usage of Signals, Queries, and Workflow Cancellation. - [**Mutex**](https://github.com/temporalio/samples-typescript/tree/main/mutex): Workflows send Signals to each other in this example of `lockWorkflow` acting as a mutex. - [**State**](https://github.com/temporalio/samples-typescript/tree/main/state): The Workflow maintains state in a `Map`, and the state can be updated and read via a Signal and a Query. - **Async activity completion**: Example of an [**Expense reporting**](https://github.com/temporalio/samples-typescript/tree/main/expense) Workflow that communicates with a server API. Shows how to kick off a Workflow and manually complete it at an arbitrarily later date. From 64f206a559a9782effc8e78670adbc4a55e82a21 Mon Sep 17 00:00:00 2001 From: Dan Davison Date: Mon, 16 Sep 2024 17:06:49 -0400 Subject: [PATCH 3/3] Housekeeping --- .github/workflows/ci.yml | 5 ++++- .scripts/copy-shared-files.mjs | 2 +- .scripts/list-of-samples.json | 3 +-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0e10bd20..474f7228 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -68,6 +68,10 @@ jobs: hello-world-js, hello-world-mtls, interceptors-opentelemetry, + message-passing/introduction, + message-passing/signals-queries-cancellation, + message-passing/execute-update, + message-passing/safe-message-handlers, monorepo-folders, mutex, nestjs-exchange-rates, @@ -79,7 +83,6 @@ jobs: saga, schedules, search-attributes, - signals-queries, sinks, snippets, state, diff --git a/.scripts/copy-shared-files.mjs b/.scripts/copy-shared-files.mjs index 22352246..9fc6f14e 100644 --- a/.scripts/copy-shared-files.mjs +++ b/.scripts/copy-shared-files.mjs @@ -59,7 +59,7 @@ const POST_CREATE_EXCLUDE = [ 'expense', 'production', 'patching-api', - 'signals-queries', + 'message-passing/signals-queries-cancellation', 'activities-cancellation-heartbeating', 'nestjs-exchange-rates', 'food-delivery', diff --git a/.scripts/list-of-samples.json b/.scripts/list-of-samples.json index 88992e6b..7b1b2572 100644 --- a/.scripts/list-of-samples.json +++ b/.scripts/list-of-samples.json @@ -32,7 +32,6 @@ "schedules", "scratchpad", "search-attributes", - "signals-queries", "sinks", "snippets", "state", @@ -42,4 +41,4 @@ "worker-specific-task-queues", "worker-versioning" ] -} \ No newline at end of file +}