Tweak bug fix

dandavison · dandavison · commit 2fd720f8e12b · 2025-01-26T22:14:42.000-05:00
diff --git a/temporalio/client.py b/temporalio/client.py
@@ -4047,6 +4047,7 @@ async def _to_proto(
             temporalio.converter.encode_search_attributes(
                 untyped_not_in_typed, action.start_workflow.search_attributes
             )
+        # TODO (dan): confirm whether this be `is not None`
         if self.typed_search_attributes:
             temporalio.converter.encode_search_attributes(
                 self.typed_search_attributes, action.start_workflow.search_attributes
@@ -6531,6 +6532,7 @@ async def update_schedule(self, input: UpdateScheduleInput) -> None:
             request_id=str(uuid.uuid4()),
         )
         if update.search_attributes is not None:
+            request.search_attributes.indexed_fields.clear()  # Ensure that we at least create an empty map
             temporalio.converter.encode_search_attributes(
                 update.search_attributes, request.search_attributes
             )
diff --git a/temporalio/converter.py b/temporalio/converter.py
@@ -1151,7 +1151,6 @@ def encode_search_attributes(
             DEPRECATED.
         api: API message to set converted attributes on.
     """
-    api.indexed_fields.clear()  # Ensure that we at least create an empty map
     if isinstance(attributes, temporalio.common.TypedSearchAttributes):
         for typed_k, typed_v in attributes:
             api.indexed_fields[typed_k.name].CopyFrom(

Original file line number	Diff line number	Diff line change
`@@ -4047,6 +4047,7 @@ async def _to_proto(`
`4047`	`4047`	`temporalio.converter.encode_search_attributes(`
`4048`	`4048`	`untyped_not_in_typed, action.start_workflow.search_attributes`
`4049`	`4049`	`)`
	`4050`	+ # TODO (dan): confirm whether this be `is not None`
`4050`	`4051`	`if self.typed_search_attributes:`
`4051`	`4052`	`temporalio.converter.encode_search_attributes(`
`4052`	`4053`	`self.typed_search_attributes, action.start_workflow.search_attributes`
`@@ -6531,6 +6532,7 @@ async def update_schedule(self, input: UpdateScheduleInput) -> None:`
`6531`	`6532`	`request_id=str(uuid.uuid4()),`
`6532`	`6533`	`)`
`6533`	`6534`	`if update.search_attributes is not None:`
	`6535`	`+ request.search_attributes.indexed_fields.clear() # Ensure that we at least create an empty map`
`6534`	`6536`	`temporalio.converter.encode_search_attributes(`
`6535`	`6537`	`update.search_attributes, request.search_attributes`
`6536`	`6538`	`)`