Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Feature Request] Dynamic activity/workflow support #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cretz opened this issue Dec 13, 2022 · 1 comment
Closed

[Feature Request] Dynamic activity/workflow support #227

cretz opened this issue Dec 13, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Dec 13, 2022

Describe the solution you'd like

@activity.defn(dynamic=True)
async def my_activity(name: str, *args: Any) -> Any:
    ...

@workflow.defn(dynamic=True)
class MyWorkflow:
    @workflow.run
    async def run(self, name: str, *args: Any) ->Any:
        ...

Something like that. Notes:

  • Make sure worker can only have one dynamic activity and/or only one dynamic workflow
  • Do we need to support payload passthrough in cases of unknown param/response type?
    • Maybe the signature should only allow *args: Any or payloads: *Payload? Same for return type?
@cretz cretz added the enhancement New feature or request label Dec 13, 2022
@cretz
Copy link
Member Author

cretz commented Jan 13, 2023

Closing in favor of duplicate #242

@cretz cretz closed this as not planned Won't fix, can't repro, duplicate, stale Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant