Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Bug] Run ID should be set in update handle #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dandavison opened this issue Dec 16, 2024 · 0 comments · Fixed by #705
Closed

[Bug] Run ID should be set in update handle #704

dandavison opened this issue Dec 16, 2024 · 0 comments · Fixed by #705
Labels
bug Something isn't working

Comments

@dandavison
Copy link
Contributor

When receiving an update response, the Python SDK does not set in the UpdateHandle the run ID of the run that the update landed on:

https://github.com/temporalio/sdk-python/blob/main/temporalio/client.py#L5339

In contrast, Typescript and Go and presumably others, all set this:

https://github.com/temporalio/sdk-typescript/blob/main/packages/client/src/workflow-client.ts#L852-L853

https://github.com/temporalio/sdk-go/blob/master/internal/internal_workflow_client.go#L2356

One consequence is that the PollWorkflowUpdate requests issued by the Python update handle do not contain a run ID (and so will land on any run), whereas for other SDKs those requests are constrained to the run that the update landed on.

It's possible that there are bugs here. For example, it seems that in Python a poll request might be able to target a different update with the same update ID, that exists in a post-CAN or post-reset run.

@dandavison dandavison added the bug Something isn't working label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant