Can you point me to the logic that whitelists the codec from the sandbox?

It's not whitelisted per se, it just runs before/after the sandbox. So we decode at

sdk-python/temporalio/worker/_workflow.py

Lines 251 to 254 in e360398

    
           if self._data_converter.payload_codec: 
        
               await temporalio.bridge.worker.decode_activation( 
        
                   act, self._data_converter.payload_codec 
        
               )

, then we let the workflow task be processed (which is subject to deadlock detection and does payload converter stuff within it), then we encode it on the way out at

sdk-python/temporalio/worker/_workflow.py

Lines 337 to 341 in e360398

    
           if self._data_converter.payload_codec: 
        
               try: 
        
                   await temporalio.bridge.worker.encode_completion( 
        
                       completion, self._data_converter.payload_codec 
        
                   )

So the logic for codecs is on the boundaries, not within the task processing. It is of course still subject to task timeouts (default 10s) so we recommend trying to make it as fast as possible (e.g. if using a KMS for encryption keys, try to cache keys locally where it makes sense instead of downloading every time).

	if self._data_converter.payload_codec:
	await temporalio.bridge.worker.decode_activation(
	act, self._data_converter.payload_codec
	)

	if self._data_converter.payload_codec:
	try:
	await temporalio.bridge.worker.encode_completion(
	completion, self._data_converter.payload_codec
	)

[Feature Request] Disabling Deadlock detection in data converters #823

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions