Recursively rebuild models in openai.types #967
Conversation
| @@ -1736,3 +1736,22 @@ async def test_workflow_method_tools(client: Client): | |||
| execution_timeout=timedelta(seconds=10), | |||
| ) | |||
| await workflow_handle.result() | |||
|
|
|||
|
|
|||
| async def test_response_serialization(): | |||
There was a problem hiding this comment.
I assume this test fails until openai/openai-agents-python#1131 (or equivalent) is merged?
There was a problem hiding this comment.
So... it does work if we explicitly rebuild all the models, but I'm hoping they will fix their dataclasses so we don't have to do this at all.
There was a problem hiding this comment.
Can you give an idea of the cost of that full model rebuild? Just confirming it doesn't take like a whole second would be good. Do you think we should wait until they fix this issue or should we model rebuild now? Also, can discuss off-PR the current status of that PR vs their other possible solutions.
There was a problem hiding this comment.
Not exactly valid statistics but I ran it a few times locally with a result of ~.2 seconds.
I'm conflicted on fixing it at the moment. I think we need a resolution for public preview, and I don't know how likely it is we get a fix from them soon. Their fix has to go through stainless and they were unable to share the PR with me.
There was a problem hiding this comment.
Similarly conflicted as it is rough continually working around broken dependencies lest we make that our default posture. Up to you.
| @@ -1736,3 +1736,22 @@ async def test_workflow_method_tools(client: Client): | |||
| execution_timeout=timedelta(seconds=10), | |||
| ) | |||
| await workflow_handle.result() | |||
|
|
|||
|
|
|||
| async def test_response_serialization(): | |||
There was a problem hiding this comment.
Similarly conflicted as it is rough continually working around broken dependencies lest we make that our default posture. Up to you.
What was changed
Recursively rebuild models in openai.types
Why?
In some scenarios, encoding would fail because the models had only been partially built on import
Checklist
Closes [Bug] pydantic_core._pydantic_core.PydanticSerializationError: Error serializing to JSON: TypeError: 'MockValSer' object cannot be converted to 'SchemaSerializer' #965
How was this tested:
New test
Any docs updates needed?