Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Feature Request] search attributes update on schedule #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jesse-triplewhale opened this issue Apr 24, 2024 · 4 comments
Open

[Feature Request] search attributes update on schedule #1402

jesse-triplewhale opened this issue Apr 24, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@jesse-triplewhale
Copy link

Happy to submit the PR myself but I wanted to check if there is a reason this is not supported?

sdk-typescript/packages/client/src/schedule-types.ts

Line 131 in e41596b

Omit<ScheduleOptions, 'scheduleId' | 'memo' | 'searchAttributes'>,

Thanks!
@jesse-triplewhale jesse-triplewhale added the enhancement New feature or request label Apr 24, 2024
@jesse-triplewhale
Copy link
Author

related? temporalio/temporal#4858

@jesse-triplewhale
Copy link
Author

My mistake - this is searchAttributes on the schedule - whereas search attributes on the workflow are action.searchAttributes. maybe renaming to scheduleSearchAttributes would reduce confusion?

@jeffmhastings
Copy link

I've run into this as well. The typescript SDK seems to ignore search attributes in the update operation. I'd like to update some existing schedules to set search attributes on the schedule itself and on the workflow.

@THardy98
Copy link
Contributor

The work for this is done #1625
We plan to release an SDK update with this change soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeffmhastings @THardy98 @jesse-triplewhale