Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: tensorflow/tensorboard
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2.11.0
Choose a base ref
...
head repository: tensorflow/tensorboard
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2.11
Choose a head ref
  • 8 commits
  • 8 files changed
  • 2 contributors

Commits on Jan 13, 2023

  1. Remove deprecated alias numpy.bool8 (#6117) 

    `numpy.bool8` is just a deprecated alias of
[`numpy.bool_`](https://numpy.org/doc/stable/reference/arrays.scalars.html#numpy.bool_).
Removed here to get rid of the deprecation warnings
(#6110).

Googlers, see cl/498031924 for internal tests.

#oncall

(cherry picked from commit 2bfdca4)
    @yatbear @arcra
    yatbear authored and arcra committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    1445d28 View commit details
    Browse the repository at this point in the history

  2. Updates references to numpy deprecated type aliases. (#6140) 

    Numpy library deprecated some type aliases in version 1.20.0 [1], and
then removed them in version 1.24.0 [2], which was released on Dec 18,
2022.

Without this change, our build would be broken when using numpy version
>= 1.24.0,
with error `AttributeError: module 'numpy' has no attribute 'float'`.

The fix suggested in release notes from numpy version 1.20.0 is to
replace these types with the equivalent primitive python types. (In this
case, simply `float`.)

[1]
http://numpy.org/doc/stable/release/1.20.0-notes.html#using-the-aliases-of-builtin-types-like-np-int-is-deprecated
[2]
http://numpy.org/doc/stable/release/1.24.0-notes.html#expired-deprecations

* Motivation for features / changes
Newer numpy versions break our build. This code is exactly equivalent,
as the identifiers used previously were aliases for the same type.

* Technical description of changes
Replace occurrences of `np.float` for the primitive type `float`.

* Screenshots of UI changes
N/A

* Detailed steps to verify changes work correctly (as executed by you)
Ran tests.

* Alternate designs / implementations considered
N/A.

(cherry picked from commit 7bcc5e8)
    @arcra
    arcra committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    fae072f View commit details
    Browse the repository at this point in the history

  3. Implements limited-input device auth flow, to replace deprecated OOB … 

    …auth flow. (#6107)

* Motivation for features / changes
The OOB auth flow has been deprecated. We concluded that the
limited-input device flow is appropriate for our use case where the
uploader runs in an environment where a browser is not available.

* Technical description of changes
Implements a new auth flow which calls an RPC to fetch a device_code,
verification_url and user_code, and asks user to visit the
verification_url in another device and enter the user_code; then starts
polling for the access token after the user authorizes the access from
another device.

* Screenshots of UI changes
N/A

* Detailed steps to verify changes work correctly (as executed by you)
- Wrote test script that uses this class, and tested the auth flow and
was able to print the credentials.
- Wrote tests.

* Alternate designs / implementations considered
Basically, implementing something similar to this flow or the OOB flow
ourselves.

(cherry picked from commit 8da06b5)
    @arcra
    arcra committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    65df3a2 View commit details
    Browse the repository at this point in the history

  4. Add 2.11.1 relnotes to RELEASE.md

    @arcra
    arcra committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    c0b17db View commit details
    Browse the repository at this point in the history

  5. TensorBoard 2.11.1

    @arcra
    arcra committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    5ad9b7a View commit details
    Browse the repository at this point in the history

  6. Fixes bug with the config passed to the "limited-input device" auth f… 

    …low (#6142)

* Motivation for features / changes
  There's a bug in the limited-input device auth flow.

The tests did not catch this issue because the config is read from a
JSON string, and the test was using an "already parsed" config
(dictionary), with a different structure from the json downloaded from
our GCP project.

* Technical description of changes
Unwraps the parsed client_config from the "installed" layer, and updates
test with a "realistic" configuration (which uses this structure).

* Screenshots of UI changes
N/A

* Detailed steps to verify changes work correctly (as executed by you)
Ran both auth flows manually (with and without browser), and updated
tests.

* Alternate designs / implementations considered
N/A
    @arcra
    arcra committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    8cc6d51 View commit details
    Browse the repository at this point in the history

  7. Add 2.11.2 relnotes to RELEASE.md

    @arcra
    arcra committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    cca2f26 View commit details
    Browse the repository at this point in the history

  8. TensorBoard 2.11.2

    @arcra
    arcra committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    76d9938 View commit details
    Browse the repository at this point in the history
Loading