fix: Remove websocket prefix from domain name output #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
reviewed
Aug 12, 2024
| @@ -103,7 +103,7 @@ output "stage_id" { | |||
|
|
|||
| output "stage_domain_name" { | |||
| description = "Domain name of the stage (useful for CloudFront distribution)" | |||
| value = replace(try(aws_apigatewayv2_stage.this[0].invoke_url, ""), "/^https?://([^/]*).*/", "$1") | |||
| value = replace(try(aws_apigatewayv2_stage.this[0].invoke_url, ""), "/^(wss?|https?)://([^/]*).*/", "$2") | |||
There was a problem hiding this comment.
quick and dirty test - looks good
bryantbiggs
approved these changes
Aug 12, 2024
c6c0b01
into
terraform-aws-modules:master
8 of 12 checks passed
antonbabenko
pushed a commit
that referenced
this pull request
Aug 12, 2024
## [5.1.3](v5.1.2...v5.1.3) (2024-08-12) ### Bug Fixes * Remove websocket prefix from domain name output ([#118](#118)) ([c6c0b01](c6c0b01))
|
This PR is included in version 5.1.3 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Strip off the
wss://prefix from the stage_domain_name output in the case of websocket api. This should fix #117Motivation and Context
We want to use a single Cloudfront domain for all our services (S3, API Gateway HTTP, API Gateway Websocket). In order to configure the Cloudfront Origin you need to pass in a domain name. I noticed that this value was not being set correctly.
Breaking Changes
I don't believe anyone would be using the incorrect domain name for websocket.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectsI ran against the websocket example before and after the change to verify that
stage_domain_nameis set correctly.pre-commit run -aon my pull request