-
-
Notifications
You must be signed in to change notification settings - Fork 713
Providing hash_extra for local_existing_package #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Source code or timestamp is probably changing, too. If it would be the same, the produced zip archive should also be the same. Could you please show the debug output as described here with |
Thanks a lot for the detailed reply, we will take a look at this when one of us has time. |
It would be great if we have some var to set the Currently, I have another tool that uploads the code to s3, so I don't use the upload from this module but the Without the option to explicitly set the The issue is quite the opposite that @andormarkus is facing but with the same solution. |
@dpeliss You can set bucket, key, and version_id like in this commented block: terraform-aws-lambda/examples/complete/main.tf Lines 142 to 146 in 6d2acf7
|
I'll need to update my buckets to be versioned, but this will do the job, thank you @antonbabenko π€ |
Fixed in #175. Please update the module to use v2.10.0 or newer. |
I'm going to lock this issue because it has been closed for 30 days β³. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Hi All,
In the current implementation
hash_extra
is only working when the package in created by this module.We are compiling our packages in the CI/CD pipeline and the hash of the .zip file keeps changing however the source code does not change.
It would be great if
hash_extra
or similarly named variable would have effect on thelocal_existing_package
as well.Implementation could look like this:
source_code_hash = (var.hash_extra != null ? var.hash_extra : local.filename == null ? false : fileexists(local.filename)) && !local.was_missing ? filebase64sha256(local.filename) : null
Thanks,
Andor
The text was updated successfully, but these errors were encountered: