Thanks to visit codestin.com
Credit goes to github.com

Skip to content

aws_iam_policy_attachment used for additional policies #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Ewande opened this issue Jul 15, 2020 · 5 comments · Fixed by #45
Closed

aws_iam_policy_attachment used for additional policies #40

Ewande opened this issue Jul 15, 2020 · 5 comments · Fixed by #45

Comments

@Ewande
Copy link
Contributor

Ewande commented Jul 15, 2020 •
edited
Loading

aws_iam_policy_attachment creates exclusive attachments, I think it makes more sense to use aws_iam_role_policy_attachment in those cases:

terraform-aws-lambda/iam.tf

Line 226 in 5ab6ccb

resource "aws_iam_policy_attachment" "additional_one" {

terraform-aws-lambda/iam.tf

Line 238 in 5ab6ccb

resource "aws_iam_policy_attachment" "additional_many" {

@codeninja55
Copy link

This should be the case for all attachments as it can override or removing existing policies from other roles.

@Ewande
Copy link
Contributor Author

Ewande commented Jul 28, 2020

As far as I can see, these two are the only ones that allow using existing policies. Other attachments either create new policies or use inline policies.

@jasonhuling
Copy link

I just ran into this issue as well... does anyone know if there are any plans to correct this?

@Ewande Ewande mentioned this issue Aug 6, 2020
Merged
@antonbabenko
Copy link
Member

I agree, it makes sense, fixed in #45, v1.20.0 has been just released.

@antonbabenko antonbabenko mentioned this issue Sep 10, 2021
Merged
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix policy attachments for managed policies Ewande/terraform-aws-lambda
4 participants
@antonbabenko @Ewande @codeninja55 @jasonhuling