d2ir: fix multiple substitutions in imports - #1914
Merged
Merged
Conversation
alixander
force-pushed
the
variable-scope
branch
from
April 17, 2024 22:59
3ac631c to
26fd144
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out we can't cache the IR for imports.
The same file may be imported into different scopes, which change the substitutions of vars. But when a cache is used, the same var in the AST gets replaced.
We can probably replace these upon returning cached result, but I think it's fickle and IR compilations are fast anyway.
closes #1892