From 98e13eb9e511a1b56c8f6e0d326dcedcd6a9fd59 Mon Sep 17 00:00:00 2001 From: Nick McCurdy Date: Thu, 19 May 2022 03:25:11 -0400 Subject: [PATCH 1/3] chore: upgrade to Jest 27 (#40) --- package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 4436388..a595faa 100644 --- a/package.json +++ b/package.json @@ -75,7 +75,7 @@ "eslint-plugin-simple-import-sort": "^5.0.3", "eslint-plugin-standard": "^4.0.1", "husky": "^4.2.5", - "jest": "^26.0.1", + "jest": "^27.0.6", "jest-watch-typeahead": "^0.6.0", "lint-staged": "^10.2.11", "preact": "^10.0.0-rc.1", @@ -114,6 +114,7 @@ ] }, "jest": { + "testEnvironment": "jsdom", "watchPlugins": [ "typeahead/filename", "typeahead/testname" From 0f19120c01ee22411428e5d4c9fa4e5148cdfaef Mon Sep 17 00:00:00 2001 From: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com> Date: Thu, 19 May 2022 10:35:40 +0200 Subject: [PATCH 2/3] Align dom-testing-library wrappers with react (#31) * test: add test * fix: align dom-testing-library wrappers with react Co-authored-by: Niklas Mischkulnig --- src/__tests__/events.js | 18 +++++++++++++----- src/pure.js | 4 ++-- 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/src/__tests__/events.js b/src/__tests__/events.js index ff0d4e2..15b7d8e 100644 --- a/src/__tests__/events.js +++ b/src/__tests__/events.js @@ -146,7 +146,7 @@ eventTypes.forEach(({ }) ) - fireEvent[eventName](ref.current, init) + expect(fireEvent[eventName](ref.current, init)).toBe(true) expect(spy).toHaveBeenCalledTimes(1) }) @@ -161,24 +161,32 @@ test('onInput works', () => { () ) - fireEvent.input(input, { target: { value: 'a' } }) + expect(fireEvent.input(input, { target: { value: 'a' } })).toBe(true) expect(handler).toHaveBeenCalledTimes(1) }) test('calling `fireEvent` directly works too', () => { - const handleEvent = jest.fn() + const handler = jest.fn() const { container: { firstChild: button } } = render( - (