Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

blimmer
Copy link
Contributor

@blimmer blimmer commented Jun 29, 2021

I'm not sure if there's a more clever way to do this, but this should work. The linked issue has a reproduction example.

Fixes #240

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #241 (b6449f3) into master (96c0c2d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #241   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           99        99           
  Branches        34        34           
=========================================
  Hits            99        99           

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 96c0c2d...b6449f3. Read the comment docs.

@@ -46,16 +46,15 @@ export interface RenderOptions<V extends Vue, S = {}>
baseElement?: Element
}

type ConfigurationArgs = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity, is this just a syntax change because TS 3.x does not support this type definition syntax?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct - I believe that format is called "named tuple" which is a new TS v4 feature.

@afontcu afontcu merged commit b028364 into testing-library:master Jul 6, 2021
@github-actions
Copy link

github-actions bot commented Jul 6, 2021

πŸŽ‰ This PR is included in version 5.8.1 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

πŸŽ‰ This PR is included in version 6.6.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type errors with TypeScript 3.9.7
2 participants