Fix prefix increment for polymorphic forms (#274)

fdintino · felton · web-flow · commit fc82a840f9a3 · 2025-10-20T11:40:54.000-04:00
Co-authored-by: Felton &lt;23240+felton@users.noreply.github.com&gt;
diff --git a/nested_admin/nested.py b/nested_admin/nested.py
@@ -368,20 +368,22 @@ def _create_formsets(self, request, obj, change):
                         is_empty_form = True
                     InlineFormSet = inline.get_formset(request, form_obj)
 
+                    # Check if we're dealing with a polymorphic instance, and if
+                    # so, skip inlines for other child models
+                    if hasattr(form_obj, "get_real_instance"):
+                        if hasattr(InlineFormSet, "fk"):
+                            rel_model = InlineFormSet.fk.remote_field.model
+                            if not isinstance(form_obj, rel_model):
+                                continue
+
                     prefix = "{}-{}".format(
                         form_prefix, InlineFormSet.get_default_prefix()
                     )
                     prefixes[prefix] = prefixes.get(prefix, 0) + 1
                     if prefixes[prefix] != 1:
                         prefix = "{}-{}".format(prefix, prefixes[prefix])
 
-                    # Check if we're dealing with a polymorphic instance, and if
-                    # so, skip inlines for other child models
                     if hasattr(form_obj, "get_real_instance"):
-                        if hasattr(InlineFormSet, "fk"):
-                            rel_model = InlineFormSet.fk.remote_field.model
-                            if not isinstance(form_obj, rel_model):
-                                continue
                         if not isinstance(form_obj, inline.parent_model):
                             continue
 
