Duplicate fields in deep inputs not validated properly (graphql#1791) (graphql#1792)

Cito · IvanGoncharov · commit a001adb67b08 · 2019-03-15T04:28:05.000+02:00
diff --git a/src/validation/__tests__/UniqueInputFieldNames-test.js b/src/validation/__tests__/UniqueInputFieldNames-test.js
@@ -88,4 +88,12 @@ describe('Validate: Unique input field names', () => {
       duplicateField('f1', 3, 22, 3, 48),
     ]);
   });
+
+  it('nested duplicate input object fields', () => {
+    expectErrors(`
+      {
+        field(arg: { f1: {f2: "value", f2: "value" }})
+      }
+    `).to.deep.equal([duplicateField('f2', 3, 27, 3, 40)]);
+  });
 });
diff --git a/src/validation/rules/UniqueInputFieldNames.js b/src/validation/rules/UniqueInputFieldNames.js
@@ -49,7 +49,6 @@ export function UniqueInputFieldNames(
       } else {
         knownNames[fieldName] = node.name;
       }
-      return false;
     },
   };
 }

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,6 @@ export function UniqueInputFieldNames(`
`49`	`49`	`} else {`
`50`	`50`	`knownNames[fieldName] = node.name;`
`51`	`51`	`}`
`52`		`- return false;`
`53`	`52`	`},`
`54`	`53`	`};`
`55`	`54`	`}`