Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ktx-mega
Copy link
Contributor

Having to hardcode the lambda function list is annoying when :

  • you have a lot of lambdas
  • you create / delete lambdas

I added a new boolean parameter called auto_update.
When set to true, the action will query all the lambda functions that include the specified layer (in any version) and update everything automatically.

You can still use the hardcoded version, of course.

@ops-gaurav
Copy link
Member

ops-gaurav commented May 11, 2024

Appreciate your contribution, @ktx-mega . I'll be reviewing this shortly.

Initially, my aim in manually selecting these function names was to ensure the safety of patching and provide developers with the ability to test this layer for target functions, rather than risking breaking everything at once (especially if the layer turns out to be faulty). However, maintaining this feature as optional, with its default setting as false, does make sense.

Could you also update the README.md in relation to this feature? It's important to clearly outline what functionalities come with which parameters and their respective tradeoffs. This will provide developers using this workflow with greater clarity and help ensure safe releases.

@ops-gaurav ops-gaurav self-assigned this May 11, 2024
@ktx-mega
Copy link
Contributor Author

I updated the README.md & rebased my fork :)

Copy link
Member

@ops-gaurav ops-gaurav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ops-gaurav ops-gaurav merged commit 31826c3 into theserverfault:main May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants