Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: thirdweb-dev/contracts
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: thirdweb-dev/contracts
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: nk/mynaswap-version-seaport
Choose a head ref
  • 18 commits
  • 17 files changed
  • 1 contributor

Commits on Feb 21, 2024

  1. POC: Seaport bulk signatures not supported by Account.isValidSignature

    @nkrishang
    nkrishang committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    90491d2 View commit details
    Browse the repository at this point in the history

  2. Add missing TypehashDirectory

    @nkrishang
    nkrishang committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    13572f3 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. WORKING SOLUTION: Account.isValidSignature supports Seaport bulk orde… 

    …r sigs
    @nkrishang
    nkrishang committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    2c389e6 View commit details
    Browse the repository at this point in the history

  2. fix compilation and tests

    @nkrishang
    nkrishang committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    8bde8ab View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Pass order params to isValidSignature for tighter verification

    @nkrishang
    nkrishang committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    ba729fd View commit details
    Browse the repository at this point in the history

  2. Create SeaportOrderEIP1271 implementation and revert Account.sol changes

    @nkrishang
    nkrishang committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    bd11c73 View commit details
    Browse the repository at this point in the history

  3. Update AccountBulkOrderSig to use ManagedAccount upgrades

    @nkrishang
    nkrishang committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    70e4e85 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2024

  1. Don't double hash in smart wallet isValidSignature replay protection

    @nkrishang
    nkrishang committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    295b00d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'nk/smart-account-eip1271-cleanup' into nk/seaport-bulk-… 

    …orders-poc
    @nkrishang
    nkrishang committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    745937b View commit details
    Browse the repository at this point in the history

  3. Update _originalMessageHash -> _hash

    @nkrishang
    nkrishang committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    1e9fe41 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'nk/smart-account-eip1271-cleanup' into nk/seaport-bulk-… 

    …orders-poc
    @nkrishang
    nkrishang committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    d391fff View commit details
    Browse the repository at this point in the history

  5. Replay protection for seaport bulk order sig

    @nkrishang
    nkrishang committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    76d5e39 View commit details
    Browse the repository at this point in the history

  6. EIP712 signature for isValidSignature

    @nkrishang
    nkrishang committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    3d5691b View commit details
    Browse the repository at this point in the history

  7. EIP712 typed data signature for isValidSignature

    @nkrishang
    nkrishang committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    b361cc1 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'nk/smart-account-eip1271-cleanup' into nk/seaport-bulk-… 

    …orders-poc
    @nkrishang
    nkrishang committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    fc55bb4 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. test undo upgrade

    @nkrishang
    nkrishang committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    af27fbf View commit details
    Browse the repository at this point in the history

  2. without replay protection

    @nkrishang
    nkrishang committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    a9e9b21 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. wip

    @nkrishang
    nkrishang committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    c71bab0 View commit details
    Browse the repository at this point in the history
Loading