Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 3, 2024. It is now read-only.

Commit 72e498d

Browse files
committed
Update Readme
- Added deprecation notice - Added instructions for documentation
1 parent f4ec4fc commit 72e498d

File tree

1 file changed

+40
-1
lines changed

1 file changed

+40
-1
lines changed

README.md

Lines changed: 40 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,26 @@
22

33
PyPi package found [here](https://pypi.org/project/thirdweb-sdk).
44

5-
## Deprecation Notice
5+
## Deprecation Notices
66

77
> The `nftlabs-sdk` pypi package will be deprecated on November 30th, 2021
88
>
99
> Please make sure you install the new `thirdweb-sdk` package found [here](https://pypi.org/project/thirdweb-sdk)
1010
>
1111
> In your code, update all imports to use the `thirdweb` package and switch to using the `ThirdwebSdk` package (instead of the `NftlabsSdk` package)
1212
13+
---
14+
15+
> The `collection` module has been renamed to `bundle` and will be deprecated on November 30th, 2021
16+
>
17+
> All references to `collection` module and its associated classes should be updated to `bundle` and its newely created classes.
18+
>
19+
> You can find the detailed documentation for the `bundle` module [here](https://python-docs.nftlabs.co/modules.bundle.html)
20+
21+
22+
23+
24+
1325

1426
### Docs
1527
https://docs.nftlabs.co
@@ -76,3 +88,30 @@ $ abi-gen --language Python -o nftlabs/abi --abis ../nftlabs-protocols/abi/NFT.j
7688
```
7789

7890
Anytime there are ABI contract changes, you should regenerate the abi wrappers.
91+
92+
93+
### Writing Documentation
94+
95+
This package uses [`PyDoctor`](https://github.com/twisted/pydoctor) to auto-generate docs. Each method, class and variable should have a detailed description of what it is meant for as a comment enclosed in triple quoation marks (`""" """`) just below the line they are defined.
96+
97+
Example:
98+
99+
Do:
100+
```python
101+
def my_method(self, arg1, arg2):
102+
"""
103+
This part goes into the documentation.
104+
"""
105+
return arg1 + arg2
106+
```
107+
108+
Don't:
109+
```python
110+
"""
111+
This part will not go into the documentation.
112+
"""
113+
114+
def my_method(self, arg1, arg2):
115+
return arg1 + arg2
116+
```
117+

0 commit comments

Comments
 (0)