Require zero address in payload (#113)

adam-maj · web-flow · commit c04ed58cacce · 2022-11-23T13:31:37.000-05:00
diff --git a/tests/test_signature_mint_721.py b/tests/test_signature_mint_721.py
@@ -119,7 +119,6 @@ def test_claiming(
     assert nft_collection.get(tx[0].id).metadata.name == "OUCH VOUCH"
     assert nft_collection.balance_of(accounts[0].address) == 10
 
-
 @pytest.mark.usefixtures("sdk", "primary_account", "secondary_account")
 def test_custom_token(
     sdk: ThirdwebSDK,
diff --git a/thirdweb/types/contracts/signature.py b/thirdweb/types/contracts/signature.py
@@ -9,7 +9,7 @@
 
 @dataclass
 class BaseSignaturePayloadInput:
-    to: str = ZERO_ADDRESS
+    to: str
     price: Price = 0
     currency_address: str = NATIVE_TOKEN_ADDRESS
     mint_start_time: int = int(time())
@@ -34,10 +34,10 @@ class Signature20PayloadOutput(Signature20PayloadInput):
 
 @dataclass
 class Signature721PayloadInput:
+    to: str
     metadata: NFTMetadataInput
     royalty_recipient: str = ZERO_ADDRESS
     royalty_bps: int = 0
-    to: str = ZERO_ADDRESS
     price: Price = 0
     currency_address: str = NATIVE_TOKEN_ADDRESS
     mint_start_time: int = int(time())
@@ -52,11 +52,11 @@ def set_uid(self, uid: str) -> "Signature721PayloadInput":
 
 @dataclass
 class Signature721PayloadOutput:
+    to: str
     metadata: NFTMetadataInput
     royalty_recipient: str = ZERO_ADDRESS
     royalty_bps: int = 0
     uri: str = ""
-    to: str = ZERO_ADDRESS
     price: Price = 0
     currency_address: str = NATIVE_TOKEN_ADDRESS
     mint_start_time: int = int(time())
@@ -71,12 +71,12 @@ def set_uid(self, uid: str) -> "Signature721PayloadOutput":
 
 @dataclass
 class Signature1155PayloadInput:
+    to: str
     metadata: NFTMetadataInput
     token_id: int
     quantity: int
     royalty_recipient: str = ZERO_ADDRESS
     royalty_bps: int = 0
-    to: str = ZERO_ADDRESS
     price: Price = 0
     currency_address: str = NATIVE_TOKEN_ADDRESS
     mint_start_time: int = int(time())
@@ -91,13 +91,13 @@ def set_uid(self, uid: str) -> "Signature1155PayloadInput":
 
 @dataclass
 class Signature1155PayloadOutput:
+    to: str
     metadata: NFTMetadataInput
     royalty_bps: int
     royalty_recipient: str
     uri: str
     token_id: int
     quantity: int
-    to: str = ZERO_ADDRESS
     price: Price = 0
     currency_address: str = NATIVE_TOKEN_ADDRESS
     mint_start_time: int = int(time())
