fix(eslint-plugin): fix autofixer for computed properties (typescript-eslint#1662)

a-tarasyuk · web-flow · commit ba22ea7f604b · 2020-03-03T00:52:40.000-08:00
diff --git a/packages/eslint-plugin/src/rules/no-unnecessary-condition.ts b/packages/eslint-plugin/src/rules/no-unnecessary-condition.ts
@@ -403,7 +403,7 @@ export default createRule<Options, MessageId>({
     function checkOptionalMemberExpression(
       node: TSESTree.OptionalMemberExpression,
     ): void {
-      checkOptionalChain(node, node.object, '.');
+      checkOptionalChain(node, node.object, node.computed ? '' : '.');
     }
 
     function checkOptionalCallExpression(
diff --git a/packages/eslint-plugin/tests/rules/no-unnecessary-condition.test.ts b/packages/eslint-plugin/tests/rules/no-unnecessary-condition.test.ts
@@ -222,6 +222,7 @@ anyValue?.();
 let unknownValue: unknown;
 unknownValue?.();
 `,
+    'const foo = [1, 2, 3][0];',
   ],
   invalid: [
     // Ensure that it's checking in all the right places
@@ -575,5 +576,18 @@ foo
         },
       ],
     },
+    {
+      code: 'const foo = [1, 2, 3]?.[0];',
+      output: 'const foo = [1, 2, 3][0];',
+      errors: [
+        {
+          messageId: 'neverOptionalChain',
+          line: 1,
+          endLine: 1,
+          column: 22,
+          endColumn: 24,
+        },
+      ],
+    },
   ],
 });

Original file line number	Diff line number	Diff line change
`@@ -403,7 +403,7 @@ export default createRule<Options, MessageId>({`
`403`	`403`	`function checkOptionalMemberExpression(`
`404`	`404`	`node: TSESTree.OptionalMemberExpression,`
`405`	`405`	`): void {`
`406`		`- checkOptionalChain(node, node.object, '.');`
	`406`	`+ checkOptionalChain(node, node.object, node.computed ? '' : '.');`
`407`	`407`	`}`
`408`	`408`
`409`	`409`	`function checkOptionalCallExpression(`