Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove duplicate chinese articles#1510

Merged
tiangolo merged 1 commit into
fastapi:masterfrom
waynerv:remove-duplicate-chinese-articles
Jun 13, 2020
Merged

Remove duplicate chinese articles#1510
tiangolo merged 1 commit into
fastapi:masterfrom
waynerv:remove-duplicate-chinese-articles

Conversation

@waynerv

@waynerv waynerv commented Jun 4, 2020

Copy link
Copy Markdown
Contributor

Since the content of the 2 Chinese articles in External Links and Articles is very simple, just a brief summary of 1 or 2 document chapters, as we now have some more detailed Chinese translation of docs, I suggest temporarily removing these 2 duplicate articles.

@codecov

codecov Bot commented Jun 4, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1510 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1510   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          227       227           
  Lines         6805      6810    +5     
=========================================
+ Hits          6805      6810    +5
Impacted Files Coverage Δ
fastapi/utils.py 100.00% <0.00%> (ø)
fastapi/openapi/utils.py 100.00% <0.00%> (ø)
fastapi/dependencies/utils.py 100.00% <0.00%> (ø)
...test_tutorial/test_path_params/test_tutorial005.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 601d8eb...e429752. Read the comment docs.

@tiangolo

tiangolo commented Jun 12, 2020

Copy link
Copy Markdown
Member

I guess that would make sense 🔥

But as I don't really know the language I would like a second opinion, just to be sure. Maybe @yanever , @Laineyzhang55 , @phy25, @Dustyposa , @RunningIkkyu , what do you think?

phy25
phy25 approved these changes Jun 12, 2020
View reviewed changes

@phy25 phy25 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first link is a very, very simple introduction. The second one is a blog's index page containing some fastapi-related articles, some of which is purely translation and some of which is the author's learning notes.

I would not say they are "duplicate", but they are not a complete walkthrough, or insight in a specific aspect. The translation of the docs should already been better than them. Just my personal opinion.

@tiangolo tiangolo merged commit 269a155 into fastapi:master Jun 13, 2020
@tiangolo

tiangolo commented Jun 13, 2020

Copy link
Copy Markdown
Member

Perfect! Thanks for the opinion @phy25 ! 🙇

Thanks for the contribution @waynerv ! 🚀

@waynerv waynerv deleted the remove-duplicate-chinese-articles branch June 14, 2020 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@phy25 phy25 phy25 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@waynerv @tiangolo @phy25