Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Normalise IntEnums to ints for route status codes#1534

Merged
tiangolo merged 5 commits into
fastapi:masterfrom
retnikt:1349
Jun 13, 2020
Merged

Normalise IntEnums to ints for route status codes#1534
tiangolo merged 5 commits into
fastapi:masterfrom
retnikt:1349

Conversation

@retnikt

@retnikt retnikt commented Jun 8, 2020

Copy link
Copy Markdown
Contributor

Fixes/related to #1349

@codecov

codecov Bot commented Jun 8, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1534 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master     #1534    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          227       234     +7     
  Lines         6810      7004   +194     
==========================================
+ Hits          6810      7004   +194     
Impacted Files Coverage Δ
fastapi/routing.py 100.00% <100.00%> (ø)
tests/main.py 100.00% <100.00%> (ø)
tests/test_application.py 100.00% <100.00%> (ø)
fastapi/params.py 100.00% <0.00%> (ø)
fastapi/encoders.py 100.00% <0.00%> (ø)
fastapi/applications.py 100.00% <0.00%> (ø)
fastapi/openapi/docs.py 100.00% <0.00%> (ø)
fastapi/openapi/utils.py 100.00% <0.00%> (ø)
fastapi/security/__init__.py 100.00% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 543ef77...56c584d. Read the comment docs.

@retnikt

retnikt commented Jun 8, 2020

Copy link
Copy Markdown
Contributor Author

@tiangolo do you have any guidance on where to test this? (as in, which tests/test_*.py file)

@Kludex

Kludex commented Jun 8, 2020

Copy link
Copy Markdown
Member

@retnikt test_custom_route_class.py is the only file that imports the routing module.

@retnikt retnikt marked this pull request as ready for review June 8, 2020 13:00
@retnikt

retnikt commented Jun 8, 2020

Copy link
Copy Markdown
Contributor Author

@Kludex I decided to put it in tests/test_application.py because that's where the OpenAPI schema seems to be tested.

@tiangolo tiangolo merged commit c6dd627 into fastapi:master Jun 13, 2020
@tiangolo

Copy link
Copy Markdown
Member

Great job @retnikt ! 🙇 🤓 🎉

Thanks @Kludex for the help! ☕

@tiangolo tiangolo mentioned this pull request Jun 13, 2020
@retnikt retnikt deleted the 1349 branch June 15, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants